qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-28 17:24:28 -06:00
Code Releases Activity

runtime: skip TestCrashDumpsAllThreads with mayMoreStackPreempt

Browse Source 
This test is flaky with in mayMoreStackPreempt mode. This is probably
revealing a real bug in the scheduler, but since it seems to only
affect TestCrashDumpsAllThreads, which is itself testing a debug mode,
I don't think this is high priority.

Updates #55160.

Change-Id: Iac558c098930ad8d4392b1e82b34f55eaec77c48
Reviewed-on: https://go-review.googlesource.com/c/go/+/501229
Reviewed-by: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
Auto-Submit: Austin Clements <austin@google.com>
This commit is contained in:
Austin Clements 2023-06-06 13:07:37 -04:00 committed by Gopher Robot
parent 89184adb9a
commit b7fc272ca9
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/runtime/crash_unix_test.go
View File

@ -14,6 +14,7 @@ import (
"os/exec"
"runtime"
"runtime/debug"
"strings"
"sync"
"syscall"
"testing"
@ -75,12 +76,20 @@ func TestCrashDumpsAllThreads(t *testing.T) {
testenv.MustHaveGoBuild(t)
if strings.Contains(os.Getenv("GCFLAGS"), "mayMoreStackPreempt") {
// This test occasionally times out in this debug mode. This is probably
// revealing a real bug in the scheduler, but since it seems to only
// affect this test and this is itself a test of a debug mode, it's not
// a high priority.
testenv.SkipFlaky(t, 55160)
}
exe, err := buildTestProg(t, "testprog")
if err != nil {
t.Fatal(err)
}
cmd := exec.Command(exe, "CrashDumpsAllThreads")
cmd := testenv.Command(t, exe, "CrashDumpsAllThreads")
cmd = testenv.CleanCmdEnv(cmd)
cmd.Env = append(cmd.Env,
"GOTRACEBACK=crash",