qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 11:55:01 -07:00
Code Releases Activity

[dev.cc] cmd/asm: add a couple of error messages for things like $exit

Browse Source 
These illegal addressing modes were caught downstream in the assembler
or link library, but we can give a better error message upstream.

Change-Id: Ib30ef4d94d5d8d44900276592edd7997e6f91e55
Reviewed-on: https://go-review.googlesource.com/4260
Reviewed-by: Russ Cox <rsc@golang.org>
This commit is contained in:
Rob Pike 2015-02-09 11:45:36 -08:00
parent cb19a20121
commit b6fd455c0d
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/cmd/asm/internal/asm/parse.go
View File

@ -290,6 +290,9 @@ func (p *Parser) operand(a *obj.Addr) bool {
a.Type = obj.TYPE_ADDR
}
a.Reg = r1
if r1 == arch.RPC && prefix != 0 {
p.errorf("illegal addressing mode for PC")
}
a.Scale = scale
p.get(')')
if scale == 0 && p.peek() == '(' {
@ -363,14 +366,22 @@ func (p *Parser) symbolReference(a *obj.Addr, name string, prefix rune) {
}
a.Sym = obj.Linklookup(p.linkCtxt, name, isStatic)
if p.peek() == scanner.EOF {
if prefix != 0 {
p.errorf("illegal addressing mode for symbol %s", name)
}
return
}
// Expect (SB) or (FP) or (SP).
// Expect (SB) or (FP), (PC), (SB), or (SP)
p.get('(')
reg := p.get(scanner.Ident).String()
switch reg {
case "FP":
a.Name = obj.NAME_PARAM
case "PC":
// Fine as is.
if prefix != 0 {
p.errorf("illegal addressing mode for PC")
}
case "SB":
a.Name = obj.NAME_EXTERN
if isStatic != 0 {