From b5c7183001889d0c7b54618dba0a1db32c2a1a23 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Mon, 27 Nov 2017 16:48:48 -0800 Subject: [PATCH] runtime: skip GDB tests on NetBSD TestGdbAutotmpTypes times out for unknown reasons on NetBSd. Skip the gdb tests on NetBSD for now. Updates #22893 Change-Id: Ibb05b7260eabb74d805d374b25a43770939fa5f2 Reviewed-on: https://go-review.googlesource.com/80136 Run-TryBot: Ian Lance Taylor Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/runtime/runtime-gdb_test.go | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/runtime/runtime-gdb_test.go b/src/runtime/runtime-gdb_test.go index f0922e16b5..fe62f96e86 100644 --- a/src/runtime/runtime-gdb_test.go +++ b/src/runtime/runtime-gdb_test.go @@ -22,11 +22,15 @@ import ( func checkGdbEnvironment(t *testing.T) { testenv.MustHaveGoBuild(t) - if runtime.GOOS == "darwin" { + switch runtime.GOOS { + case "darwin": t.Skip("gdb does not work on darwin") - } - if runtime.GOOS == "linux" && runtime.GOARCH == "ppc64" { - t.Skip("skipping gdb tests on linux/ppc64; see golang.org/issue/17366") + case "netbsd": + t.Skip("test times out on NetBSD for unknown reasons; issue 22893") + case "linux": + if runtime.GOARCH == "ppc64" { + t.Skip("skipping gdb tests on linux/ppc64; see golang.org/issue/17366") + } } if final := os.Getenv("GOROOT_FINAL"); final != "" && runtime.GOROOT() != final { t.Skip("gdb test can fail with GOROOT_FINAL pending")