qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-16 20:14:48 -07:00
Code Releases Activity

go/types,types2: exclude tests that need cgo.Incomplete

Browse Source 
Since when go/types,types2 do not know about build constraints, and
runtime/cgo.Incomplete is only available on platforms that support cgo.

These tests are also failing on aix with failure from linker, so disable
them on aix to make builder green. The fix for aix is tracked in #54814

Updates #46731
Updates #54814

Change-Id: I5d6f6e29a8196efc6c457ea64525350fc6b20309
Reviewed-on: https://go-review.googlesource.com/c/go/+/427394
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
This commit is contained in:
Cuong Manh Le 2022-09-01 10:32:20 +07:00 committed by Keith Randall
parent 91ef076562
commit b5b2cf519f
8 changed files with 24 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/cmd/compile/internal/types2/stdlib_test.go
View File

@ -197,6 +197,15 @@ func TestStdFixed(t *testing.T) {
"issue48230.go", // go/types doesn't check validity of //go:xxx directives
"issue49767.go", // go/types does not have constraints on channel element size
"issue49814.go", // go/types does not have constraints on array size
// These tests requires runtime/cgo.Incomplete, which is only available on some platforms.
// However, types2 does not know about build constraints.
"bug514.go",
"issue40954.go",
"issue42032.go",
"issue42076.go",
"issue46903.go",
"issue51733.go",
)
}

9
src/go/types/stdlib_test.go
View File

@ -199,6 +199,15 @@ func TestStdFixed(t *testing.T) {
"issue48230.go", // go/types doesn't check validity of //go:xxx directives
"issue49767.go", // go/types does not have constraints on channel element size
"issue49814.go", // go/types does not have constraints on array size
// These tests requires runtime/cgo.Incomplete, which is only available on some platforms.
// However, go/types does not know about build constraints.
"bug514.go",
"issue40954.go",
"issue42032.go",
"issue42076.go",
"issue46903.go",
"issue51733.go",
)
}

2
test/fixedbugs/bug514.go
View File

@ -4,7 +4,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
//go:build cgo
//go:build cgo && !aix
package main

2
test/fixedbugs/issue40954.go
View File

@ -4,7 +4,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
//go:build cgo
//go:build cgo && !aix
package main

2
test/fixedbugs/issue42032.go
View File

@ -4,7 +4,7 @@
// source code is governed by a BSD-style license that can be found in
// the LICENSE file.
//go:build cgo
//go:build cgo && !aix
package main

2
test/fixedbugs/issue42076.go
View File

@ -4,7 +4,7 @@
// source code is governed by a BSD-style license that can be found in
// the LICENSE file.
//go:build cgo
//go:build cgo && !aix
package main

3
test/fixedbugs/issue46903.go
View File

@ -1,6 +1,5 @@
// run
//go:build goexperiment.unified && cgo
// +build goexperiment.unified,cgo
//go:build goexperiment.unified && cgo && !aix
// TODO(mdempsky): Enable test unconditionally. This test should pass
// for non-unified mode too.

2
test/fixedbugs/issue51733.go
View File

@ -4,7 +4,7 @@
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
//go:build cgo
//go:build cgo && !aix
package main