qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-10-04 12:21:26 -06:00
Code Releases Activity

net/rpc: use RunParallel in benchmarks

Browse Source 
LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://golang.org/cl/68040044
This commit is contained in:
Dmitriy Vyukov 2014-02-24 20:23:35 +04:00
parent 0ef0d6cd7b
commit b5705ed9ab
1 changed files with 13 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/pkg/net/rpc/server_test.go
View File

@ -594,7 +594,6 @@ func TestErrorAfterClientClose(t *testing.T) {
} }
func benchmarkEndToEnd(dial func() (*Client, error), b *testing.B) { func benchmarkEndToEnd(dial func() (*Client, error), b *testing.B) {
b.StopTimer()
once.Do(startServer) once.Do(startServer)
client, err := dial() client, err := dial()
if err != nil { if err != nil {
@ -604,16 +603,11 @@ func benchmarkEndToEnd(dial func() (*Client, error), b *testing.B) {
// Synchronous calls // Synchronous calls
args := &Args{7, 8} args := &Args{7, 8}
procs := runtime.GOMAXPROCS(-1) b.ResetTimer()
N := int32(b.N)
var wg sync.WaitGroup
wg.Add(procs)
b.StartTimer()
for p := 0; p < procs; p++ { b.RunParallel(func(pb *testing.PB) {
go func() {
reply := new(Reply) reply := new(Reply)
for atomic.AddInt32(&N, -1) >= 0 { for pb.Next() {
err := client.Call("Arith.Add", args, reply) err := client.Call("Arith.Add", args, reply)
if err != nil { if err != nil {
b.Fatalf("rpc error: Add: expected no error but got string %q", err.Error()) b.Fatalf("rpc error: Add: expected no error but got string %q", err.Error())
@ -622,15 +616,11 @@ func benchmarkEndToEnd(dial func() (*Client, error), b *testing.B) {
b.Fatalf("rpc error: Add: expected %d got %d", reply.C, args.A+args.B) b.Fatalf("rpc error: Add: expected %d got %d", reply.C, args.A+args.B)
} }
} }
wg.Done() })
}()
}
wg.Wait()
} }
func benchmarkEndToEndAsync(dial func() (*Client, error), b *testing.B) { func benchmarkEndToEndAsync(dial func() (*Client, error), b *testing.B) {
const MaxConcurrentCalls = 100 const MaxConcurrentCalls = 100
b.StopTimer()
once.Do(startServer) once.Do(startServer)
client, err := dial() client, err := dial()
if err != nil { if err != nil {
@ -647,7 +637,7 @@ func benchmarkEndToEndAsync(dial func() (*Client, error), b *testing.B) {
wg.Add(procs) wg.Add(procs)
gate := make(chan bool, MaxConcurrentCalls) gate := make(chan bool, MaxConcurrentCalls)
res := make(chan *Call, MaxConcurrentCalls) res := make(chan *Call, MaxConcurrentCalls)
b.StartTimer() b.ResetTimer()
for p := 0; p < procs; p++ { for p := 0; p < procs; p++ {
go func() { go func() {