qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-29 07:14:29 -06:00
Code Releases Activity

crypto: use t.Parallel() to increase speed

Browse Source 
It is necessary to invoke the t.Parallel() method in both the top-level test function and its subtest function to maximize parallelism. In doing so, all subtest functions calling the t.Parallel() method in the package will work in parallel.

On my machine, the execution time of this test file was cut in half.

Change-Id: If09147a2a9969bb044932d71e6bfea29492866d6
Reviewed-on: https://go-review.googlesource.com/c/go/+/482755
Run-TryBot: shuang cui <imcusg@gmail.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Roland Shoemaker <roland@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
This commit is contained in:
cui fliter 2023-04-06 17:08:49 +08:00 committed by Gopher Robot
parent 527745c4d5
commit b4eed1c341
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/crypto/elliptic/elliptic_test.go
View File

@ -48,6 +48,7 @@ func testAllCurves(t *testing.T, f func(*testing.T, Curve)) {
} }
func TestOnCurve(t *testing.T) { func TestOnCurve(t *testing.T) {
t.Parallel()
testAllCurves(t, func(t *testing.T, curve Curve) { testAllCurves(t, func(t *testing.T, curve Curve) {
if !curve.IsOnCurve(curve.Params().Gx, curve.Params().Gy) { if !curve.IsOnCurve(curve.Params().Gx, curve.Params().Gy) {
t.Error("basepoint is not on the curve") t.Error("basepoint is not on the curve")
@ -56,6 +57,7 @@ func TestOnCurve(t *testing.T) {
} }
func TestOffCurve(t *testing.T) { func TestOffCurve(t *testing.T) {
t.Parallel()
testAllCurves(t, func(t *testing.T, curve Curve) { testAllCurves(t, func(t *testing.T, curve Curve) {
x, y := new(big.Int).SetInt64(1), new(big.Int).SetInt64(1) x, y := new(big.Int).SetInt64(1), new(big.Int).SetInt64(1)
if curve.IsOnCurve(x, y) { if curve.IsOnCurve(x, y) {
@ -76,6 +78,7 @@ func TestOffCurve(t *testing.T) {
} }
func TestInfinity(t *testing.T) { func TestInfinity(t *testing.T) {
t.Parallel()
testAllCurves(t, testInfinity) testAllCurves(t, testInfinity)
} }
@ -150,6 +153,7 @@ func testInfinity(t *testing.T, curve Curve) {
} }
func TestMarshal(t *testing.T) { func TestMarshal(t *testing.T) {
t.Parallel()
testAllCurves(t, func(t *testing.T, curve Curve) { testAllCurves(t, func(t *testing.T, curve Curve) {
_, x, y, err := GenerateKey(curve, rand.Reader) _, x, y, err := GenerateKey(curve, rand.Reader)
if err != nil { if err != nil {
@ -167,6 +171,7 @@ func TestMarshal(t *testing.T) {
} }
func TestUnmarshalToLargeCoordinates(t *testing.T) { func TestUnmarshalToLargeCoordinates(t *testing.T) {
t.Parallel()
// See https://golang.org/issues/20482. // See https://golang.org/issues/20482.
testAllCurves(t, testUnmarshalToLargeCoordinates) testAllCurves(t, testUnmarshalToLargeCoordinates)
} }
@ -216,6 +221,7 @@ func testUnmarshalToLargeCoordinates(t *testing.T, curve Curve) {
// (negative or bigger than P). They are expected to return false from // (negative or bigger than P). They are expected to return false from
// IsOnCurve, all other behavior is undefined. // IsOnCurve, all other behavior is undefined.
func TestInvalidCoordinates(t *testing.T) { func TestInvalidCoordinates(t *testing.T) {
t.Parallel()
testAllCurves(t, testInvalidCoordinates) testAllCurves(t, testInvalidCoordinates)
} }
@ -268,6 +274,7 @@ func testInvalidCoordinates(t *testing.T, curve Curve) {
} }
func TestMarshalCompressed(t *testing.T) { func TestMarshalCompressed(t *testing.T) {
t.Parallel()
t.Run("P-256/03", func(t *testing.T) { t.Run("P-256/03", func(t *testing.T) {
data, _ := hex.DecodeString("031e3987d9f9ea9d7dd7155a56a86b2009e1e0ab332f962d10d8beb6406ab1ad79") data, _ := hex.DecodeString("031e3987d9f9ea9d7dd7155a56a86b2009e1e0ab332f962d10d8beb6406ab1ad79")
x, _ := new(big.Int).SetString("13671033352574878777044637384712060483119675368076128232297328793087057702265", 10) x, _ := new(big.Int).SetString("13671033352574878777044637384712060483119675368076128232297328793087057702265", 10)
@ -326,6 +333,7 @@ func testMarshalCompressed(t *testing.T, curve Curve, x, y *big.Int, want []byte
} }
func TestLargeIsOnCurve(t *testing.T) { func TestLargeIsOnCurve(t *testing.T) {
t.Parallel()
testAllCurves(t, func(t *testing.T, curve Curve) { testAllCurves(t, func(t *testing.T, curve Curve) {
large := big.NewInt(1) large := big.NewInt(1)
large.Lsh(large, 1000) large.Lsh(large, 1000)