qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 11:38:01 -07:00
Code Releases Activity

runtime/pprof: expect tests to pass on macOS

Browse Source 
macOS tests have been disabled since CL 12429045 (Aug 2013).
At the time, macOS required a kernel patch to get a working profiler
(https://research.swtch.com/macpprof), which we didn't want
to require, of course.

macOS has improved - it no longer requires the kernel patch - but
we never updated the list of exceptions.

As far as I can tell, the builders have no problem passing the pprof test now.
(It is possible that the iOS builders have trouble, but that is now a different GOOS.)

Remove the exception for macOS. The test should now pass.

Fixes #6047.

Change-Id: Iab49036cacc1025e56f515bd19d084390c2f5357
Reviewed-on: https://go-review.googlesource.com/c/go/+/292229
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
This commit is contained in:
Russ Cox 2021-02-15 17:02:30 -05:00
parent b110a43628
commit b445d6ea34
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/runtime/pprof/pprof_test.go
View File

@ -279,7 +279,7 @@ func testCPUProfile(t *testing.T, matches matchFunc, need []string, avoid []stri
broken := false broken := false
switch runtime.GOOS { switch runtime.GOOS {
case "darwin", "ios", "dragonfly", "netbsd", "illumos", "solaris": case "ios", "dragonfly", "netbsd", "illumos", "solaris":
broken = true broken = true
case "openbsd": case "openbsd":
if runtime.GOARCH == "arm" || runtime.GOARCH == "arm64" { if runtime.GOARCH == "arm" || runtime.GOARCH == "arm64" {