mirror of
https://github.com/golang/go
synced 2024-11-11 20:20:23 -07:00
cmd/compile: add call to ImportedBody() when exporting shape inst body
When we export a shape instantiation, because a particular fully-instantiated type is needed by an inlineable function, we possibly export the body of the instantiation, if it is inlineable. In this case, we should have been calling ImportedBody() to make sure that the function body had already been read in (if it is actually imported from another package). Fixes #50598 Change-Id: I512d2bcc745faa6ff3a97e25bc8f46e2c2643d23 Reviewed-on: https://go-review.googlesource.com/c/go/+/378494 Trust: Dan Scales <danscales@google.com> Run-TryBot: Dan Scales <danscales@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
parent
e550c30545
commit
b41185c5c3
@ -252,6 +252,7 @@ func (p *crawler) checkForFullyInst(t *types.Type) {
|
||||
if HaveInlineBody(methNode.Func) {
|
||||
// Export the body as well if
|
||||
// instantiation is inlineable.
|
||||
ImportedBody(methNode.Func)
|
||||
methNode.Func.SetExportInline(true)
|
||||
}
|
||||
}
|
||||
|
23
test/typeparam/issue50598.dir/a0.go
Normal file
23
test/typeparam/issue50598.dir/a0.go
Normal file
@ -0,0 +1,23 @@
|
||||
// Copyright 2022 The Go Authors. All rights reserved.
|
||||
// Use of this source code is governed by a BSD-style
|
||||
// license that can be found in the LICENSE file.
|
||||
|
||||
package a0
|
||||
|
||||
type Builder[T any] struct{}
|
||||
|
||||
func (r Builder[T]) New1() T {
|
||||
var v T
|
||||
return v
|
||||
}
|
||||
|
||||
func (r Builder[T]) New2() T {
|
||||
var v T
|
||||
return v
|
||||
}
|
||||
|
||||
type IntBuilder struct{}
|
||||
|
||||
func (b IntBuilder) New() int {
|
||||
return Builder[int]{}.New2()
|
||||
}
|
11
test/typeparam/issue50598.dir/a1.go
Normal file
11
test/typeparam/issue50598.dir/a1.go
Normal file
@ -0,0 +1,11 @@
|
||||
// Copyright 2022 The Go Authors. All rights reserved.
|
||||
// Use of this source code is governed by a BSD-style
|
||||
// license that can be found in the LICENSE file.
|
||||
|
||||
package a1
|
||||
|
||||
import "a0"
|
||||
|
||||
func New() int {
|
||||
return a0.IntBuilder{}.New()
|
||||
}
|
11
test/typeparam/issue50598.dir/a2.go
Normal file
11
test/typeparam/issue50598.dir/a2.go
Normal file
@ -0,0 +1,11 @@
|
||||
// Copyright 2022 The Go Authors. All rights reserved.
|
||||
// Use of this source code is governed by a BSD-style
|
||||
// license that can be found in the LICENSE file.
|
||||
|
||||
package a2
|
||||
|
||||
import "a0"
|
||||
|
||||
func New() int {
|
||||
return a0.Builder[int]{}.New1()
|
||||
}
|
22
test/typeparam/issue50598.dir/main.go
Normal file
22
test/typeparam/issue50598.dir/main.go
Normal file
@ -0,0 +1,22 @@
|
||||
// Copyright 2022 The Go Authors. All rights reserved.
|
||||
// Use of this source code is governed by a BSD-style
|
||||
// license that can be found in the LICENSE file.
|
||||
|
||||
package main
|
||||
|
||||
import (
|
||||
"fmt"
|
||||
|
||||
"a1"
|
||||
"a2"
|
||||
)
|
||||
|
||||
func New() int {
|
||||
return a1.New() + a2.New()
|
||||
}
|
||||
|
||||
func main() {
|
||||
if got, want := New(), 0; got != want {
|
||||
panic(fmt.Sprintf("got %d, want %d", got, want))
|
||||
}
|
||||
}
|
7
test/typeparam/issue50598.go
Normal file
7
test/typeparam/issue50598.go
Normal file
@ -0,0 +1,7 @@
|
||||
// rundir -G=3
|
||||
|
||||
// Copyright 2022 The Go Authors. All rights reserved.
|
||||
// Use of this source code is governed by a BSD-style
|
||||
// license that can be found in the LICENSE file.
|
||||
|
||||
package ignored
|
Loading…
Reference in New Issue
Block a user