qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 17:04:47 -07:00
Code Releases Activity

debug/gosym: simplify parsing symbol name rule

Browse Source 
Symbol name with linker prefix like "type." and "go." is not parsed
correctly and returns the prefix as parts of package name.

So just returns empty string for symbol name start with linker prefix.

Fixes #29551

Change-Id: Idb4ce872345e5781a5a5da2b2146faeeebd9e63b
Reviewed-on: https://go-review.googlesource.com/c/go/+/156397
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
LE Manh Cuong 2019-01-05 01:42:44 +07:00 committed by Ian Lance Taylor
parent 91c9ed0840
commit b37b35edd7
2 changed files with 26 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/debug/gosym/symtab.go
View File

@ -35,13 +35,21 @@ func (s *Sym) Static() bool { return s.Type >= 'a' }
// PackageName returns the package part of the symbol name,
// or the empty string if there is none.
func (s *Sym) PackageName() string {
pathend := strings.LastIndex(s.Name, "/")
name := s.Name
// A prefix of "type." and "go." is a compiler-generated symbol that doesn't belong to any package.
// See variable reservedimports in cmd/compile/internal/gc/subr.go
if strings.HasPrefix(name, "go.") || strings.HasPrefix(name, "type.") {
return ""
}
pathend := strings.LastIndex(name, "/")
if pathend < 0 {
pathend = 0
}
if i := strings.Index(s.Name[pathend:], "."); i != -1 {
return s.Name[:pathend+i]
if i := strings.Index(name[pathend:], "."); i != -1 {
return name[:pathend+i]
}
return ""
}

15
src/debug/gosym/symtab_test.go
View File

@ -41,3 +41,18 @@ func TestRemotePackage(t *testing.T) {
assertString(t, fmt.Sprintf("receiver of %q", s1.Name), s1.ReceiverName(), "(*FlagSet)")
assertString(t, fmt.Sprintf("receiver of %q", s2.Name), s2.ReceiverName(), "")
}
func TestIssue29551(t *testing.T) {
symNames := []string{
"type..eq.[9]debug/elf.intName",
"type..hash.debug/elf.ProgHeader",
"type..eq.runtime._panic",
"type..hash.struct { runtime.gList; runtime.n int32 }",
"go.(*struct { sync.Mutex; math/big.table [64]math/big",
}
for _, symName := range symNames {
s := Sym{Name: symName}
assertString(t, fmt.Sprintf("package of %q", s.Name), s.PackageName(), "")
}
}