From b34b0aaf69349f060d3b03a06f520848964cb7eb Mon Sep 17 00:00:00 2001 From: xiaodong liu Date: Thu, 12 Nov 2020 08:12:08 +0000 Subject: [PATCH] cmd/go: skip TestScript/build_plugin_non_main on platforms that do not support -buildmode=plugin Fixes #42474 Change-Id: I1550b44b92cd272854e2f17493245a14e3d39f41 GitHub-Last-Rev: 948d01716eff41c25515dfb6135769862977aba1 GitHub-Pull-Request: golang/go#42475 Reviewed-on: https://go-review.googlesource.com/c/go/+/268737 Reviewed-by: Bryan C. Mills Reviewed-by: Jay Conrod Trust: Jay Conrod --- src/cmd/go/testdata/script/build_plugin_non_main.txt | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/cmd/go/testdata/script/build_plugin_non_main.txt b/src/cmd/go/testdata/script/build_plugin_non_main.txt index 3c82dced73..e0bbbefb19 100644 --- a/src/cmd/go/testdata/script/build_plugin_non_main.txt +++ b/src/cmd/go/testdata/script/build_plugin_non_main.txt @@ -1,7 +1,5 @@ -# Plugins are only supported on linux,cgo (!riscv64) and darwin,cgo. -[!linux] [!darwin] skip -[linux] [riscv64] skip -[!cgo] skip +# Plugins are not supported on all platforms. +[!buildmode:plugin] skip go build -n testdep ! go build -buildmode=plugin testdep