From b2a76986510e1d23982e13eaf8a70d8380433012 Mon Sep 17 00:00:00 2001 From: Alan Donovan Date: Wed, 30 Dec 2015 11:36:47 -0500 Subject: [PATCH] go/loader: in stdlib_test, remove workaround for lack of vendoring Change-Id: I058081ef596e8b5231321ef05d5256ec44cc58c6 Reviewed-on: https://go-review.googlesource.com/18214 Reviewed-by: Alan Donovan --- go/loader/stdlib_test.go | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/go/loader/stdlib_test.go b/go/loader/stdlib_test.go index a76f62b860..2d7c12e715 100644 --- a/go/loader/stdlib_test.go +++ b/go/loader/stdlib_test.go @@ -7,8 +7,6 @@ package loader_test // This file enumerates all packages beneath $GOROOT, loads them, plus // their external tests if any, runs the type checker on them, and // prints some summary information. -// -// Run test with GOMAXPROCS=8. import ( "bytes" @@ -28,17 +26,6 @@ import ( "golang.org/x/tools/go/types" ) -// The set of packages that transitively depend on cmd/internal/objfile, -// which uses vendoring, which go/loader does not yet support. -// TODO(adonovan): add support for vendoring and delete this. -var skip = map[string]bool{ - "cmd/addr2line": true, - "cmd/internal/objfile": true, - "cmd/nm": true, - "cmd/objdump": true, - "cmd/pprof": true, -} - func TestStdlib(t *testing.T) { if runtime.GOOS == "android" { t.Skipf("incomplete std lib on %s", runtime.GOOS) @@ -55,9 +42,6 @@ func TestStdlib(t *testing.T) { ctxt.GOPATH = "" // disable GOPATH conf := loader.Config{Build: &ctxt} for _, path := range buildutil.AllPackages(conf.Build) { - if skip[path] { - continue - } conf.ImportWithTests(path) }