qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-25 11:57:58 -07:00
Code Releases Activity

testing: use temp dir without symlinks in TestChdir/relative

Browse Source 
When paths with symlinks are involved, it's not viable to compare them
with string equality. Don't use a temporary directory with symlinks in
it as input, so the test works in more environments.

For #62516.

Change-Id: I95d774365cc2f90eb0ffcffa61229ed5cee43e3e
Reviewed-on: https://go-review.googlesource.com/c/go/+/607035
Reviewed-by: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
This commit is contained in:
Dmitri Shuralyov 2024-08-20 10:07:05 -04:00 committed by Gopher Robot
parent 98ed865a9e
commit b292799ddd
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/testing/testing_test.go
View File

@ -293,7 +293,11 @@ func TestChdir(t *testing.T) {
}
defer os.Chdir(oldDir)
tmp := t.TempDir()
// The "relative" test case relies on tmp not being a symlink.
tmp, err := filepath.EvalSymlinks(t.TempDir())
if err != nil {
t.Fatal(err)
}
rel, err := filepath.Rel(oldDir, tmp)
if err != nil {
t.Fatal(err)