qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 22:30:02 -07:00
Code Releases Activity

cmd/compile: optimize types.sconv

Browse Source 
Now that symfmt is simpler, we can simply manually inline it into
sconv. Importantly, this allows us to avoid allocating a buffer +
writing a string + re-interning it when we don't need to qualify the
identifier.

Passes toolstash -cmp.

Updates #47087.

Change-Id: I47b57aef22301ba242556a645346f478f0c1a7d1
Reviewed-on: https://go-review.googlesource.com/c/go/+/333162
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
This commit is contained in:
Matthew Dempsky 2021-07-07 12:33:40 -07:00
parent 11f5df2d67
commit b003a8b1ae
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/cmd/compile/internal/types/fmt.go
View File

@ -112,11 +112,19 @@ func sconv(s *Sym, verb rune, mode fmtMode) string {
if s.Name == "_" { if s.Name == "_" {
return "_" return "_"
} }
q := pkgqual(s.Pkg, verb, mode)
if q == "" {
return s.Name
}
buf := fmtBufferPool.Get().(*bytes.Buffer) buf := fmtBufferPool.Get().(*bytes.Buffer)
buf.Reset() buf.Reset()
defer fmtBufferPool.Put(buf) defer fmtBufferPool.Put(buf)
symfmt(buf, s, verb, mode) buf.WriteString(q)
buf.WriteByte('.')
buf.WriteString(s.Name)
return InternString(buf.Bytes()) return InternString(buf.Bytes())
} }