qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 04:07:59 -07:00
Code Releases Activity

cmd/compile: fix bug in phiopt pass

Browse Source 
The math to invert the input index was wrong.

Fixes #45323

Change-Id: I7c68cac280e8f01a9c806ecb0f195f169267437e
Reviewed-on: https://go-review.googlesource.com/c/go/+/306431
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: fannie zhang <Fannie.Zhang@arm.com>
Reviewed-by: David Chase <drchase@google.com>
This commit is contained in:
Keith Randall 2021-03-31 23:58:54 -07:00
parent 97b3ce430b
commit aebc0b473e
2 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/compile/internal/ssa/phiopt.go
View File

@ -213,7 +213,7 @@ func phiopt(f *Func) {
ei := b.Preds[1].i
sb0 := pb1.Succs[1-ei].b
if sdom.IsAncestorEq(sb0, pb0) {
convertPhi(pb1, v, ei-1)
convertPhi(pb1, v, 1-ei)
break
}
} else {

24
test/fixedbugs/issue45323.go Normal file
View File

@ -0,0 +1,24 @@
// compile
// Copyright 2021 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package main
func g() bool
func f(y int) bool {
b, ok := true, false
if y > 1 {
ok = g()
}
if !ok {
ok = g()
b = false
}
if !ok {
return false
}
return b
}