From adf220a5d5ecaa407401e5f46a8460e97bbca64d Mon Sep 17 00:00:00 2001 From: Michael Matloob Date: Mon, 9 Sep 2024 12:47:33 -0400 Subject: [PATCH] cmd/go/testdata/script: skip part of test on unsupported platforms The telemetry script test checks for the existence of telemetry data as a baseline before checking that the act of setting telemtetry to off while in local mode doesn't produce telemetry data. Of course, when we're running on platforms where telemetry is not supported, telemetry data won't be produced on disk either way. Only check for the existence of telemetry data on supported platforms. For #69269 Change-Id: I3a06bbc3d3ca0cf0203b84883f632ecfd9445aae Reviewed-on: https://go-review.googlesource.com/c/go/+/611876 Reviewed-by: Robert Findley LUCI-TryBot-Result: Go LUCI Auto-Submit: Michael Matloob --- src/cmd/go/testdata/script/telemetry.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/cmd/go/testdata/script/telemetry.txt b/src/cmd/go/testdata/script/telemetry.txt index 7edbe66b5f..52bf8dee64 100644 --- a/src/cmd/go/testdata/script/telemetry.txt +++ b/src/cmd/go/testdata/script/telemetry.txt @@ -52,7 +52,8 @@ stderr '^go: GOTELEMETRYDIR cannot be modified$' # Test issue #69269: 'go telemetry off' should not increment counters. # Establish that previous commands did write telemetry files. -exists $userconfig/go/telemetry/local +# Only check for the existence of telemetry data on supported platforms. +[!GOOS:openbsd] [!GOOS:solaris] [!GOOS:android] [!GOOS:illumos] [!GOOS:js] [!GOOS:wasip1] [!GOOS:plan9] [!GOARCH:mips] [!GOARCH:mipsle] exists $userconfig/go/telemetry/local # Now check for go telemetry off behavior. rm $userconfig/go/telemetry/local go telemetry off @@ -66,4 +67,4 @@ go telemetry -C=$WORK off ! exists $userconfig/go/telemetry/local go telemetry local go help telemetry -exists $userconfig/go/telemetry/local +[!GOOS:openbsd] [!GOOS:solaris] [!GOOS:android] [!GOOS:illumos] [!GOOS:js] [!GOOS:wasip1] [!GOOS:plan9] [!GOARCH:mips] [!GOARCH:mipsle] exists $userconfig/go/telemetry/local