From adead1a93f472affa97c494ef19f2f492ee6f34a Mon Sep 17 00:00:00 2001 From: qmuntal Date: Thu, 18 Jan 2024 07:53:50 +0100 Subject: [PATCH] cmd/cgo/internal/test: skip TestCallbackCallersSEH when internal linking TestCallbackCallersSEH is flaky when using the internal linker. Skip it for now until the flakiness is resolved. Updates #65116 Change-Id: I7628b07eaff8be00757d5604722f30aede25fce5 Reviewed-on: https://go-review.googlesource.com/c/go/+/556635 Reviewed-by: Cherry Mui Reviewed-by: Carlos Amedee LUCI-TryBot-Result: Go LUCI --- .../internal/test/seh_internal_windows_test.go | 16 ++++++++++++++++ .../{cgo_windows_test.go => seh_windows_test.go} | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 src/cmd/cgo/internal/test/seh_internal_windows_test.go rename src/cmd/cgo/internal/test/{cgo_windows_test.go => seh_windows_test.go} (87%) diff --git a/src/cmd/cgo/internal/test/seh_internal_windows_test.go b/src/cmd/cgo/internal/test/seh_internal_windows_test.go new file mode 100644 index 0000000000..708ffdc6f6 --- /dev/null +++ b/src/cmd/cgo/internal/test/seh_internal_windows_test.go @@ -0,0 +1,16 @@ +// Copyright 2024 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +//go:build cgo && windows && internal + +package cgotest + +import ( + "internal/testenv" + "testing" +) + +func TestCallbackCallersSEH(t *testing.T) { + testenv.SkipFlaky(t, 65116) +} diff --git a/src/cmd/cgo/internal/test/cgo_windows_test.go b/src/cmd/cgo/internal/test/seh_windows_test.go similarity index 87% rename from src/cmd/cgo/internal/test/cgo_windows_test.go rename to src/cmd/cgo/internal/test/seh_windows_test.go index 7bbed5b04e..4a8d5bbd4d 100644 --- a/src/cmd/cgo/internal/test/cgo_windows_test.go +++ b/src/cmd/cgo/internal/test/seh_windows_test.go @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. -//go:build cgo && windows +//go:build cgo && windows && !internal package cgotest