mirror of
https://github.com/golang/go
synced 2024-11-20 04:44:40 -07:00
net/http: clarify that Request.Host may contain a port number
Fixes #4172 R=golang-dev, dsymonds CC=golang-dev https://golang.org/cl/6872055
This commit is contained in:
parent
23ca24018a
commit
add1bed735
@ -124,6 +124,7 @@ type Request struct {
|
||||
// The host on which the URL is sought.
|
||||
// Per RFC 2616, this is either the value of the Host: header
|
||||
// or the host name given in the URL itself.
|
||||
// It may be of the form "host:port".
|
||||
Host string
|
||||
|
||||
// Form contains the parsed form data, including both the URL
|
||||
|
@ -228,6 +228,16 @@ func TestReadRequestErrors(t *testing.T) {
|
||||
}
|
||||
}
|
||||
|
||||
func TestNewRequestHost(t *testing.T) {
|
||||
req, err := NewRequest("GET", "http://localhost:1234/", nil)
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if req.Host != "localhost:1234" {
|
||||
t.Errorf("Host = %q; want localhost:1234", req.Host)
|
||||
}
|
||||
}
|
||||
|
||||
func testMissingFile(t *testing.T, req *Request) {
|
||||
f, fh, err := req.FormFile("missing")
|
||||
if f != nil {
|
||||
|
@ -224,7 +224,7 @@ type URL struct {
|
||||
Scheme string
|
||||
Opaque string // encoded opaque data
|
||||
User *Userinfo // username and password information
|
||||
Host string
|
||||
Host string // host or host:port
|
||||
Path string
|
||||
RawQuery string // encoded query values, without '?'
|
||||
Fragment string // fragment for references, without '#'
|
||||
|
Loading…
Reference in New Issue
Block a user