qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-15 00:20:30 -07:00
Code Releases Activity

go/types, types2: use correct predicate when asserting comma-ok types

Browse Source 
While at it and unrelated, up-date testdata/manual.go sample file so
we can just copy its contents into a test file after debugging, without
fixing the date.

Fixes #66878.

Change-Id: Ie49a341b78d99bdc0f1a0ba1ca42fa2d3a807bd6
Reviewed-on: https://go-review.googlesource.com/c/go/+/580075
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Robert Griesemer 2024-04-18 08:51:27 -07:00 committed by Gopher Robot
parent a0205e650a
commit ad87d44047
5 changed files with 25 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/compile/internal/types2/check.go
View File

@ -600,7 +600,7 @@ func (check *Checker) recordCommaOkTypes(x syntax.Expr, a []*operand) {
return
}
t0, t1 := a[0].typ, a[1].typ
assert(isTyped(t0) && isTyped(t1) && (isBoolean(t1) || t1 == universeError))
assert(isTyped(t0) && isTyped(t1) && (allBoolean(t1) || t1 == universeError))
if m := check.Types; m != nil {
for {
tv := m[x]

2
src/cmd/compile/internal/types2/testdata/manual.go vendored
View File

@ -1,4 +1,4 @@
// Copyright 2023 The Go Authors. All rights reserved.
// Copyright 2024 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

2
src/go/types/check.go
View File

@ -579,7 +579,7 @@ func (check *Checker) recordCommaOkTypes(x ast.Expr, a []*operand) {
return
}
t0, t1 := a[0].typ, a[1].typ
assert(isTyped(t0) && isTyped(t1) && (isBoolean(t1) || t1 == universeError))
assert(isTyped(t0) && isTyped(t1) && (allBoolean(t1) || t1 == universeError))
if m := check.Types; m != nil {
for {
tv := m[x]

2
src/go/types/testdata/manual.go vendored
View File

@ -1,4 +1,4 @@
// Copyright 2023 The Go Authors. All rights reserved.
// Copyright 2024 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.

21
src/internal/types/testdata/fixedbugs/issue66878.go vendored Normal file
View File

@ -0,0 +1,21 @@
// Copyright 2024 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package p
func _[T bool](ch chan T) {
var _, _ T = <-ch
}
// offending code snippets from issue
func _[T ~bool](ch <-chan T) {
var x, ok T = <-ch
println(x, ok)
}
func _[T ~bool](m map[int]T) {
var x, ok T = m[0]
println(x, ok)
}