From ad665e4fde1878dbc8d3893bf8b4ddbe2f83ccff Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Thu, 15 Jul 2010 16:43:06 -0700 Subject: [PATCH] codereview: don't run gofmt with an empty file list R=gri CC=golang-dev https://golang.org/cl/1678054 --- lib/codereview/codereview.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py index 750ae871ca..4aeff90678 100644 --- a/lib/codereview/codereview.py +++ b/lib/codereview/codereview.py @@ -694,6 +694,8 @@ def CheckGofmt(ui, repo, files, just_warn=False): cwd = os.getcwd() files = [RelativePath(repo.root + '/' + f, cwd) for f in files] files = [f for f in files if os.access(f, 0)] + if not files: + return try: cmd = subprocess.Popen(["gofmt", "-l"] + files, shell=False, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True) cmd.stdin.close()