From acfdaf06f573c7b483515aed451c5148e32d6e60 Mon Sep 17 00:00:00 2001 From: qmuntal Date: Fri, 21 Oct 2022 09:18:53 +0200 Subject: [PATCH] runtime: skip TestVectoredHandlerExceptionInNonGoThread windows-amd-2012 builder seems to have some problems handling exception thrown in external C code which is affecting TestVectoredHandlerExceptionInNonGoThread. The issue is known and discussed in #49681. This Cl skips the offending test on windows-amd-2012. Change-Id: I7ca4353c9e531f0d75ac6a8dbd809acfa1f15bf9 Reviewed-on: https://go-review.googlesource.com/c/go/+/444616 Reviewed-by: Bryan Mills Reviewed-by: Michael Pratt Auto-Submit: Michael Pratt Run-TryBot: Quim Muntal TryBot-Result: Gopher Robot --- src/runtime/signal_windows_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/runtime/signal_windows_test.go b/src/runtime/signal_windows_test.go index 02497e6fae..b27eca9b60 100644 --- a/src/runtime/signal_windows_test.go +++ b/src/runtime/signal_windows_test.go @@ -21,6 +21,9 @@ func TestVectoredHandlerExceptionInNonGoThread(t *testing.T) { if *flagQuick { t.Skip("-quick") } + if testenv.Builder() == "windows-amd64-2012" { + testenv.SkipFlaky(t, 49681) + } testenv.MustHaveGoBuild(t) testenv.MustHaveCGO(t) testenv.MustHaveExecPath(t, "gcc")