From ace5fa1a609c28cbfcede4639d3eed47c47b2774 Mon Sep 17 00:00:00 2001 From: Tobias Klauser Date: Tue, 10 Apr 2018 12:19:24 +0200 Subject: [PATCH] runtime: remove support_bmi{1,2} The code reading these variables was removed in CL 41476. They are only set but never read now, so remove them. Change-Id: I6b0b8d813e9a3ec2a13586ff92746e00ad1b5bf0 Reviewed-on: https://go-review.googlesource.com/106095 Run-TryBot: Tobias Klauser TryBot-Result: Gobot Gobot Reviewed-by: Ian Lance Taylor --- src/runtime/asm_386.s | 6 ------ src/runtime/asm_amd64.s | 6 ------ src/runtime/asm_amd64p32.s | 6 ------ src/runtime/runtime2.go | 2 -- 4 files changed, 20 deletions(-) diff --git a/src/runtime/asm_386.s b/src/runtime/asm_386.s index 8b706f6706..806361b6b8 100644 --- a/src/runtime/asm_386.s +++ b/src/runtime/asm_386.s @@ -198,17 +198,11 @@ eax7: MOVL $0, CX CPUID - TESTL $(1<<3), BX // BMI1 - SETNE runtime·support_bmi1(SB) - // If OS support for XMM and YMM is not present // support_avx2 will be set back to false later. TESTL $(1<<5), BX SETNE runtime·support_avx2(SB) - TESTL $(1<<8), BX // BMI2 - SETNE runtime·support_bmi2(SB) - TESTL $(1<<9), BX // ERMS SETNE runtime·support_erms(SB) diff --git a/src/runtime/asm_amd64.s b/src/runtime/asm_amd64.s index 16e9f5fe40..db516b5492 100644 --- a/src/runtime/asm_amd64.s +++ b/src/runtime/asm_amd64.s @@ -161,17 +161,11 @@ eax7: MOVL $0, CX CPUID - TESTL $(1<<3), BX // BMI1 - SETNE runtime·support_bmi1(SB) - // If OS support for XMM and YMM is not present // support_avx2 will be set back to false later. TESTL $(1<<5), BX SETNE runtime·support_avx2(SB) - TESTL $(1<<8), BX // BMI2 - SETNE runtime·support_bmi2(SB) - TESTL $(1<<9), BX // ERMS SETNE runtime·support_erms(SB) diff --git a/src/runtime/asm_amd64p32.s b/src/runtime/asm_amd64p32.s index 160dc556d4..04f78d8d93 100644 --- a/src/runtime/asm_amd64p32.s +++ b/src/runtime/asm_amd64p32.s @@ -81,17 +81,11 @@ eax7: MOVL $0, CX CPUID - TESTL $(1<<3), BX // BMI1 - SETNE runtime·support_bmi1(SB) - // If OS support for XMM and YMM is not present // support_avx2 will be set back to false later. TESTL $(1<<5), BX SETNE runtime·support_avx2(SB) - TESTL $(1<<8), BX // BMI2 - SETNE runtime·support_bmi2(SB) - TESTL $(1<<9), BX // ERMS SETNE runtime·support_erms(SB) diff --git a/src/runtime/runtime2.go b/src/runtime/runtime2.go index 72a80a6907..ee5f6d5b47 100644 --- a/src/runtime/runtime2.go +++ b/src/runtime/runtime2.go @@ -774,8 +774,6 @@ var ( support_aes bool support_avx bool support_avx2 bool - support_bmi1 bool - support_bmi2 bool support_erms bool support_osxsave bool support_popcnt bool