qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-12 09:50:21 -07:00
Code Releases Activity

runtime: fix scanning of gc work buffer

Browse Source 
GC types were not being generated for the garbage collector
work buffer.  The markfor object was being collected as a result.
This broke amd64p32 and maybe plan9 builds.  Why it didn't break
every build I'm not sure...

Fixes #8812

LGTM=0intro, rsc
R=golang-codereviews, dave, khr, 0intro, rsc
CC=golang-codereviews
https://golang.org/cl/149260043
This commit is contained in:
Keith Randall 2014-09-30 08:51:02 -07:00
parent 12308d5a0b
commit ac9218f5f0
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/runtime/mgc0.c
View File

@ -140,7 +140,8 @@ static BitVector unrollglobgcprog(byte *prog, uintptr size);
void runtime·bgsweep(void);
static FuncVal bgsweepv = {runtime·bgsweep};
struct {
typedef struct WorkData WorkData;
struct WorkData {
uint64 full; // lock-free list of full blocks
uint64 empty; // lock-free list of empty blocks
byte pad0[CacheLineSize]; // prevents false-sharing between full/empty and nproc/nwait
@ -154,7 +155,8 @@ struct {
// Copy of mheap.allspans for marker or sweeper.
MSpan** spans;
uint32 nspan;
} runtime·work;
};
WorkData runtime·work;
// scanblock scans a block of n bytes starting at pointer b for references
// to other objects, scanning any it finds recursively until there are no
@ -1038,7 +1040,8 @@ runtime·MSpan_Sweep(MSpan *s, bool preserve)
// State of background runtime·sweep.
// Protected by runtime·gclock.
struct
typedef struct SweepData SweepData;
struct SweepData
{
G* g;
bool parked;
@ -1047,7 +1050,8 @@ struct
uint32 nbgsweep;
uint32 npausesweep;
} runtime·sweep;
};
SweepData runtime·sweep;
// sweeps one span
// returns number of pages returned to heap, or -1 if there is nothing to sweep