From ac7efcb0caac712395adf602f69d2ff3ace6e16e Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Wed, 1 Feb 2023 02:11:01 +0700 Subject: [PATCH] test: enable inlining tests for functions with local type Updates #57410 Change-Id: Ibe1f5523a4635d2b844b9a5db94514e07eb0bc0f Reviewed-on: https://go-review.googlesource.com/c/go/+/463998 Reviewed-by: Keith Randall Auto-Submit: Cuong Manh Le TryBot-Result: Gopher Robot Run-TryBot: Cuong Manh Le Reviewed-by: Matthew Dempsky --- test/escape4.go | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/test/escape4.go b/test/escape4.go index e381248476c..710eb751262 100644 --- a/test/escape4.go +++ b/test/escape4.go @@ -38,11 +38,7 @@ func f2() {} // ERROR "can inline f2" func f3() { panic(1) } // ERROR "can inline f3" "1 escapes to heap" func f4() { recover() } -// TODO(cuonglm): remove f5, f6 //go:noinline and update the error message -// once GOEXPERIMENT=nounified is gone. - -//go:noinline -func f5() *byte { +func f5() *byte { // ERROR "can inline f5" type T struct { x [1]byte } @@ -50,8 +46,7 @@ func f5() *byte { return &t.x[0] } -//go:noinline -func f6() *byte { +func f6() *byte { // ERROR "can inline f6" type T struct { x struct { y byte