qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-21 17:24:42 -07:00
Code Releases Activity

internal/poll: disable SIO_UDP_NETRESET on Windows

Browse Source 
Windows UDP sockets have novel behavior in response to ICMP, where by
default RecvFrom will receive a read error as a result of an incoming
ICMP packet. This behavior is not portable or consistent with behavior
on other platforms, so for consistency it is disabled here.

This is similar to, but a different case from the prior change 3114bd6 /
https://golang.org/issue/5834 that disabled one of the two flags
influencing behavior in response to the reception of related ICMP.

Updates #5834
Updates #68614
This commit is contained in:
James Tucker 2024-07-26 14:10:57 -07:00
parent 9e40780a46
commit ab6ab507fc
No known key found for this signature in database
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/internal/poll/fd_windows.go
View File

@ -337,8 +337,8 @@ func (fd *FD) Init(net string, pollable bool) (string, error) {
fd.skipSyncNotif = true
}
}
// Disable SIO_UDP_CONNRESET behavior.
// http://support.microsoft.com/kb/263823
// Disable SIO_UDP_CONNRESET and SIO_UDP_NETRESET behavior.
// http://support.microsoft.com/kb/263823 / https://golang.org/issue/68614
switch net {
case "udp", "udp4", "udp6":
ret := uint32(0)
@ -348,6 +348,14 @@ func (fd *FD) Init(net string, pollable bool) (string, error) {
if err != nil {
return "wsaioctl", err
}
ret := uint32(0)
flag := uint32(0)
size := uint32(unsafe.Sizeof(flag))
err := syscall.WSAIoctl(fd.Sysfd, syscall.SIO_UDP_NETRESET, (*byte)(unsafe.Pointer(&flag)), size, nil, 0, &ret, nil, 0)
if err != nil {
return "wsaioctl", err
}
}
fd.rop.mode = 'r'
fd.wop.mode = 'w'