qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 18:44:42 -07:00
Code Releases Activity

x/tools/dashboard/app: respect gohash in Commit.AddResult

Browse Source 
This should fix the issue where results sub-repo results are clobbered
by subsequent commits. (Much like the previous fix, which only
fixed the issue for main repo commits.)

TBR=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/167440044
This commit is contained in:
Andrew Gerrand 2014-11-10 13:58:29 +11:00
parent 8bd0dd9d19
commit ab43333964
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dashboard/app/build/build.go
View File

@ -154,7 +154,7 @@ func (com *Commit) AddResult(c appengine.Context, r *Result) error {
var resultExists bool var resultExists bool
for i, s := range com.ResultData { for i, s := range com.ResultData {
// if there already exists result data for this builder at com, overwrite it. // if there already exists result data for this builder at com, overwrite it.
if strings.HasPrefix(s, r.Builder+"|") { if strings.HasPrefix(s, r.Builder+"|") && strings.HasSuffix(s, "|"+r.GoHash) {
resultExists = true resultExists = true
com.ResultData[i] = r.Data() com.ResultData[i] = r.Data()
} }