qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 07:34:44 -07:00
Code Releases Activity

testing/race: fixing intermittent test failure

Browse Source 
Test NoRaceMutexPureHappensBefore in runtime/race/testdata/mutex_test.go
expects the second spawned goroutine to run after the first.  The test
attempts to force this scheduling with a 10 millisecond wait.  Following
a suggestion by Bryan Mills, we force this scheduling using a shared
variable whose access take place within the existing mutex.

Fixes #35745.

Change-Id: Ib23ec51492ecfeed4752e020401dd25755a669ed
Reviewed-on: https://go-review.googlesource.com/c/go/+/291292
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
This commit is contained in:
Daniel S. Fava 2021-02-12 09:54:50 +01:00 committed by Bryan C. Mills
parent fbed561f8a
commit aaed6cbced
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/runtime/race/testdata/mutex_test.go vendored
View File

@ -78,16 +78,23 @@ func TestNoRaceMutexPureHappensBefore(t *testing.T) {
var mu sync.Mutex var mu sync.Mutex
var x int16 = 0 var x int16 = 0
_ = x _ = x
written := false
ch := make(chan bool, 2) ch := make(chan bool, 2)
go func() { go func() {
x = 1 x = 1
mu.Lock() mu.Lock()
written = true
mu.Unlock() mu.Unlock()
ch <- true ch <- true
}() }()
go func() { go func() {
<-time.After(1e5) time.Sleep(100 * time.Microsecond)
mu.Lock() mu.Lock()
for !written {
mu.Unlock()
time.Sleep(100 * time.Microsecond)
mu.Lock()
}
mu.Unlock() mu.Unlock()
x = 1 x = 1
ch <- true ch <- true