1
0
mirror of https://github.com/golang/go synced 2024-11-19 08:44:39 -07:00

fmt: replace variables for type bit sizes with constants

Use constants instead of dynamically computed values to determine
the bit sizes of types similar to how strconv and other packages
directly compute these sizes. Move these constants near the code
that uses them.

Change-Id: I78d113b7e697466097e32653975df5990380c2c1
Reviewed-on: https://go-review.googlesource.com/20514
Run-TryBot: Rob Pike <r@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
This commit is contained in:
Martin Möhrmann 2016-03-10 16:11:35 +01:00 committed by Rob Pike
parent 5630cb7518
commit a9d0244c33
2 changed files with 7 additions and 7 deletions

View File

@ -578,11 +578,6 @@ func (p *pp) fmtPointer(value reflect.Value, verb rune) {
}
}
var (
intBits = reflect.TypeOf(0).Bits()
uintptrBits = reflect.TypeOf(uintptr(0)).Bits()
)
func (p *pp) catchPanic(arg interface{}, verb rune) {
if err := recover(); err != nil {
// If it's a nil pointer, just say "<nil>". The likeliest causes are a

View File

@ -915,9 +915,14 @@ func (s *ss) hexString() string {
return string(s.buf)
}
const floatVerbs = "beEfFgGv"
const (
floatVerbs = "beEfFgGv"
const hugeWid = 1 << 30
hugeWid = 1 << 30
intBits = 32 << (^uint(0) >> 63)
uintptrBits = 32 << (^uintptr(0) >> 63)
)
// scanOne scans a single value, deriving the scanner from the type of the argument.
func (s *ss) scanOne(verb rune, arg interface{}) {