qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 14:14:46 -07:00
Code Releases Activity

internal/telemetry: use keys properly for benchmarks

Browse Source 
Change-Id: I571628db26a5b89fd567077d90d325fd76301956
Reviewed-on: https://go-review.googlesource.com/c/tools/+/222598
Run-TryBot: Ian Cottrell <iancottrell@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
This commit is contained in:
Ian Cottrell 2020-03-08 00:03:39 -05:00
parent 68dc0f3515
commit a9aaa4e906
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
internal/telemetry/bench_test.go
View File

@ -18,8 +18,10 @@ type Hooks struct {
}
var (
aValue = event.Key("a")
bValue = event.Key("b")
aCount = stats.Int64("aCount", "Count of time A is called.", unit.Dimensionless)
aValue = stats.Int64("aValue", "A value.", unit.Dimensionless)
aStat = stats.Int64("aValue", "A value.", unit.Dimensionless)
bCount = stats.Int64("B", "Count of time B is called.", unit.Dimensionless)
bLength = stats.Int64("BLen", "B length.", unit.Dimensionless)
@ -49,15 +51,15 @@ var (
Log = Hooks{
A: func(ctx context.Context, a *int) (context.Context, func()) {
event.Print(ctx, "start A", event.TagOf("a", *a))
event.Print(ctx, "start A", aValue.Of(*a))
return ctx, func() {
event.Print(ctx, "end A", event.TagOf("a", *a))
event.Print(ctx, "end A", aValue.Of(*a))
}
},
B: func(ctx context.Context, b *string) (context.Context, func()) {
event.Print(ctx, "start B", event.TagOf("b", *b))
event.Print(ctx, "start B", bValue.Of(*b))
return ctx, func() {
event.Print(ctx, "end B", event.TagOf("b", *b))
event.Print(ctx, "end B", bValue.Of(*b))
}
},
}
@ -75,7 +77,7 @@ var (
A: func(ctx context.Context, a *int) (context.Context, func()) {
aCount.Record(ctx, 1)
return ctx, func() {
aValue.Record(ctx, int64(*a))
aStat.Record(ctx, int64(*a))
}
},
B: func(ctx context.Context, b *string) (context.Context, func()) {