qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 14:54:40 -07:00
Code Releases Activity

internal/lps/protocol: bring code.ts up to date with latest changes.

Browse Source 
This CL makes sure that code.ts will generate the latest version
of tsprotocol.go. It has a more succinct way of deciding which fields
need to be pointers.

Change-Id: I6854cb2f096d3707bc3b828a9601f9384638f475
Reviewed-on: https://go-review.googlesource.com/c/tools/+/212140
Run-TryBot: Peter Weinberger <pjw@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This commit is contained in:
Peter Weinberger 2019-12-19 11:25:26 -05:00
parent 2ad5dca7a5
commit a98e7fcfeb
1 changed files with 15 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
internal/lsp/protocol/typescript/code.ts
View File

@ -466,6 +466,13 @@ function toGo(d: Data, nm: string) {
`more cases in toGo ${nm} ${d.as.length} ${d.generics.length} `)
}
// these fields need a *
var starred: [string, string][] = [
['TextDocumentContentChangeEvent', 'range'], ['CodeAction', 'command'],
['DidSaveTextDocumentParams', 'text'], ['CompletionItem', 'command'],
['CompletionItem', 'textEdit']
];
// generate Go code for an interface
function goInterface(d: Data, nm: string) {
let ans = `type ${goName(nm)} struct {\n`;
@ -479,18 +486,10 @@ function goInterface(d: Data, nm: string) {
// SelectionRange is a recursive type
let gt = goType(n.type, n.name.getText());
if (gt == d.name) gt = '*' + gt; // avoid recursive types
// There's a difference between a nil Range and a zero Range (at the
// beginning of files)
if (d.name == 'TextDocumentContentChangeEvent' &&
n.name.getText() == 'range') {
gt = '*' + gt;
}
if (d.name == 'CodeAction' && n.name.getText() == 'command') {
gt = '*' + gt;
}
if (d.name == 'DidSaveTextDocumentParams' && n.name.getText() == 'text') {
gt = '*' + gt;
}
// there are several cases where a * is needed
starred.forEach(([a, b]) => {
if (d.name == a && n.name.getText() == b) gt = '*' + gt
});
ans = ans.concat(`${goName(n.name.getText())} ${gt}`, json, '\n')
};
d.properties.forEach(g)
@ -650,8 +649,8 @@ function goUnionType(n: ts.UnionTypeNode, nm: string): string {
const bb = strKind(n.types[1])
const cc = strKind(n.types[2])
if (nm == 'DocumentFilter') {
// not really a union. the first is enough, up to a missing omitempty
// but avoid repetitious comments
// not really a union. the first is enough, up to a missing
// omitempty but avoid repetitious comments
return `${goType(n.types[0], 'g')}`
}
if (nm == 'textDocument/documentSymbol') {
@ -856,7 +855,8 @@ const notNil = `if r.Params != nil {
return true
}`;
// Go code for notifications. Side is client or server, m is the request method
// Go code for notifications. Side is client or server, m is the request
// method
function goNot(side: side, m: string) {
if (m == '$/cancelRequest') return; // handled specially in protocol.go
const n = not.get(m);