qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-10-04 23:21:20 -06:00
Code Releases Activity

cmd/compile: don't generate algs for map buckets

Browse Source 
Note that this is only safe because
the compiler generates multiple distinct
gc.Types. If we switch to having canonical
gc.Types, then this will need to be updated
to handle the case in which the user uses both
map[T]S and also map[[8]T]S. In that case,
the runtime needs algs for [8]T, but this could
mark the sole [8]T type as Noalg. This is a general
problem with having a single bool to represent
whether alg generation is needed for a type.

Cuts 5k off cmd/go and 22k off golang.org/x/tools/cmd/godoc,
approx 0.04% and 0.12% respectively.

For #6853 and #9930

Change-Id: I30a15ec72ecb62e2aa053260a7f0f75015fc0ade
Reviewed-on: https://go-review.googlesource.com/19769
Reviewed-by: David Crawshaw <crawshaw@golang.org>
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Josh Bleecher Snyder 2015-05-04 15:01:03 -07:00
parent b6b144bf97
commit a6abc1cd70
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/cmd/compile/internal/gc/reflect.go
View File

@ -102,13 +102,18 @@ func mapbucket(t *Type) *Type {
valtype = Ptrto(valtype) valtype = Ptrto(valtype)
} }
field := make([]*Field, 0, 5)
// The first field is: uint8 topbits[BUCKETSIZE]. // The first field is: uint8 topbits[BUCKETSIZE].
arr := typArray(Types[TUINT8], BUCKETSIZE) arr := typArray(Types[TUINT8], BUCKETSIZE)
field := make([]*Field, 0, 5)
field = append(field, makefield("topbits", arr)) field = append(field, makefield("topbits", arr))
arr = typArray(keytype, BUCKETSIZE) arr = typArray(keytype, BUCKETSIZE)
arr.Noalg = true
field = append(field, makefield("keys", arr)) field = append(field, makefield("keys", arr))
arr = typArray(valtype, BUCKETSIZE) arr = typArray(valtype, BUCKETSIZE)
arr.Noalg = true
field = append(field, makefield("values", arr)) field = append(field, makefield("values", arr))
// Make sure the overflow pointer is the last memory in the struct, // Make sure the overflow pointer is the last memory in the struct,