qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-11 20:50:23 -07:00
Code Releases Activity

misc/cgo: disable testcarchive, testplugin during -short test (including all.bash)

Browse Source 
These tests take 20 seconds each to rebuild the entire world
in their respective modes. That's too much for short mode,
including all.bash on developer machines.

Keep doing it on builders and if someone runs 'go test' by hand
in that directory.

For #26473.

Change-Id: I3dc6955bc3aa7a20fd170efcde72a7d19b37bdbf
Reviewed-on: https://go-review.googlesource.com/c/go/+/177417
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Russ Cox 2019-05-15 14:31:48 -04:00
parent 018d9b42a7
commit a6a0ed3c47
4 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
misc/cgo/testcarchive/carchive_test.go
View File

@ -8,6 +8,7 @@ import (
"bufio"
"bytes"
"debug/elf"
"flag"
"fmt"
"io/ioutil"
"log"
@ -36,6 +37,11 @@ var GOOS, GOARCH, GOPATH string
var libgodir string
func TestMain(m *testing.M) {
flag.Parse()
if testing.Short() && os.Getenv("GO_BUILDER_NAME") == "" {
fmt.Printf("SKIP - short mode and $GO_BUILDER_NAME not set\n")
os.Exit(0)
}
log.SetFlags(log.Lshortfile)
os.Exit(testMain(m))
}

6
misc/cgo/testcshared/cshared_test.go
View File

@ -7,6 +7,7 @@ package cshared_test
import (
"bytes"
"debug/elf"
"flag"
"fmt"
"io/ioutil"
"log"
@ -36,6 +37,11 @@ func TestMain(m *testing.M) {
func testMain(m *testing.M) int {
log.SetFlags(log.Lshortfile)
flag.Parse()
if testing.Short() && os.Getenv("GO_BUILDER_NAME") == "" {
fmt.Printf("SKIP - short mode and $GO_BUILDER_NAME not set\n")
os.Exit(0)
}
GOOS = goEnv("GOOS")
GOARCH = goEnv("GOARCH")

6
misc/cgo/testplugin/plugin_test.go
View File

@ -7,6 +7,7 @@ package plugin_test
import (
"bytes"
"context"
"flag"
"fmt"
"io/ioutil"
"log"
@ -22,6 +23,11 @@ import (
var gcflags string = os.Getenv("GO_GCFLAGS")
func TestMain(m *testing.M) {
flag.Parse()
if testing.Short() && os.Getenv("GO_BUILDER_NAME") == "" {
fmt.Printf("SKIP - short mode and $GO_BUILDER_NAME not set\n")
os.Exit(0)
}
log.SetFlags(log.Lshortfile)
os.Exit(testMain(m))
}

2
src/cmd/dist/test.go vendored
View File

@ -991,7 +991,7 @@ func (t *tester) runHostTest(dir, pkg string) error {
if err := cmd.Run(); err != nil {
return err
}
return t.dirCmd(dir, "./test.test").Run()
return t.dirCmd(dir, "./test.test", "-test.short").Run()
}
func (t *tester) cgoTest(dt *distTest) error {