qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 10:04:56 -07:00
Code Releases Activity

cmd/internal/objfile: minor edits

Browse Source 
Follow-up in response to comments on
TBR'ed CL 171260043.

LGTM=r
R=r
CC=golang-codereviews
https://golang.org/cl/172080043
This commit is contained in:
Russ Cox 2014-11-09 20:21:37 -05:00
parent 2ad99f0960
commit a697c4b439
1 changed files with 14 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/cmd/internal/objfile/disasm.go
View File

@ -1,3 +1,7 @@
// Copyright 2014 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package objfile package objfile
import ( import (
@ -17,14 +21,14 @@ import (
// Disasm is a disassembler for a given File. // Disasm is a disassembler for a given File.
type Disasm struct { type Disasm struct {
syms []Sym syms []Sym //symbols in file, sorted by address
pcln *gosym.Table pcln *gosym.Table // pcln table
text []byte text []byte // bytes of text segment (actual instructions)
textStart uint64 textStart uint64 // start PC of text
textEnd uint64 textEnd uint64 // end PC of text
goarch string goarch string // GOARCH string
disasm disasmFunc disasm disasmFunc // disassembler function for goarch
byteOrder binary.ByteOrder byteOrder binary.ByteOrder // byte order for goarch
} }
// Disasm returns a disassembler for the file f. // Disasm returns a disassembler for the file f.
@ -89,7 +93,8 @@ func (d *Disasm) lookup(addr uint64) (name string, base uint64) {
} }
// base returns the final element in the path. // base returns the final element in the path.
// It works on both Windows and Unix paths. // It works on both Windows and Unix paths,
// regardless of host operating system.
func base(path string) string { func base(path string) string {
path = path[strings.LastIndex(path, "/")+1:] path = path[strings.LastIndex(path, "/")+1:]
path = path[strings.LastIndex(path, `\`)+1:] path = path[strings.LastIndex(path, `\`)+1:]