qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-20 01:54:41 -07:00
Code Releases Activity

container/heap: call t.Helper() in verify()

Browse Source 
I modified verify() to fail every time to test the change. Before adding
t.Helper() (line 37 is in verify()):
/.../go/src/container/heap/heap_test.go:37: forced failure
FAIL

Afer adding t.Helper() (line 67 is where verify() is called):
/.../go/src/container/heap/heap_test.go:67: forced failure
FAIL

Fixes #21863

Change-Id: I46f0c8ec413cc664358c568fc53e48bb4a1d03d0
Reviewed-on: https://go-review.googlesource.com/63570
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Tyler Bui-Palsulich 2017-09-13 08:09:21 -07:00 committed by Ian Lance Taylor
parent de22318888
commit a696277243
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/container/heap/heap_test.go
View File

@ -33,6 +33,7 @@ func (h *myHeap) Push(v interface{}) {
} }
func (h myHeap) verify(t *testing.T, i int) { func (h myHeap) verify(t *testing.T, i int) {
t.Helper()
n := h.Len() n := h.Len()
j1 := 2*i + 1 j1 := 2*i + 1
j2 := 2*i + 2 j2 := 2*i + 2