From a431bdc712c7a404307f38228271d970d9d2c023 Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Mon, 17 Oct 2016 23:19:10 -0400 Subject: [PATCH] testing: document that Skip cannot undo Error Fixes #16502. Change-Id: Id8e117a724d73cd51844c06d47bbeba61f8dc827 Reviewed-on: https://go-review.googlesource.com/31324 Reviewed-by: Brad Fitzpatrick Reviewed-by: Marcel van Lohuizen --- src/testing/testing.go | 1 + 1 file changed, 1 insertion(+) diff --git a/src/testing/testing.go b/src/testing/testing.go index 7ca9d49605..3dcc5afef9 100644 --- a/src/testing/testing.go +++ b/src/testing/testing.go @@ -520,6 +520,7 @@ func (c *common) Skipf(format string, args ...interface{}) { } // SkipNow marks the test as having been skipped and stops its execution. +// If a test fails (see Error, Errorf, Fail) and is then skipped, it is still considered to have failed. // Execution will continue at the next test or benchmark. See also FailNow. // SkipNow must be called from the goroutine running the test, not from // other goroutines created during the test. Calling SkipNow does not stop