qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-20 04:44:40 -07:00
Code Releases Activity

cmd/gc: racewalk: instrument returnsfromheap params

Browse Source 
Fixes #4307.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6822073
This commit is contained in:
Dmitriy Vyukov 2012-11-07 12:10:35 +04:00
parent abb313f8c8
commit a3a7244779
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/cmd/gc/racewalk.c
View File

@ -45,6 +45,10 @@ racewalk(Node *fn)
} }
} }
racewalklist(fn->nbody, nil);
// nothing interesting for race detector in fn->enter
racewalklist(fn->exit, nil);
// nodpc is the PC of the caller as extracted by // nodpc is the PC of the caller as extracted by
// getcallerpc. We use -widthptr(FP) for x86. // getcallerpc. We use -widthptr(FP) for x86.
// BUG: this will not work on arm. // BUG: this will not work on arm.
@ -56,15 +60,14 @@ racewalk(Node *fn)
fn->enter = concat(list1(nd), fn->enter); fn->enter = concat(list1(nd), fn->enter);
nd = mkcall("racefuncexit", T, nil); nd = mkcall("racefuncexit", T, nil);
fn->exit = list(fn->exit, nd); fn->exit = list(fn->exit, nd);
racewalklist(curfn->nbody, nil);
if(debug['W']) { if(debug['W']) {
snprint(s, sizeof(s), "after racewalk %S", curfn->nname->sym); snprint(s, sizeof(s), "after racewalk %S", fn->nname->sym);
dumplist(s, curfn->nbody); dumplist(s, fn->nbody);
snprint(s, sizeof(s), "after walk %S", curfn->nname->sym); snprint(s, sizeof(s), "enter %S", fn->nname->sym);
dumplist(s, curfn->nbody); dumplist(s, fn->enter);
snprint(s, sizeof(s), "enter %S", curfn->nname->sym); snprint(s, sizeof(s), "exit %S", fn->nname->sym);
dumplist(s, curfn->enter); dumplist(s, fn->exit);
} }
} }
@ -311,8 +314,9 @@ racewalknode(Node **np, NodeList **init, int wr, int skip)
// does not require instrumentation // does not require instrumentation
case OINDEXMAP: // implemented in runtime case OINDEXMAP: // implemented in runtime
case OPRINT: // don't bother instrumenting it case OPRINT: // don't bother instrumenting it
case OPRINTN: // don't bother instrumenting it case OPRINTN: // don't bother instrumenting it
case OPARAM: // it appears only in fn->exit to copy heap params back
goto ret; goto ret;
// unimplemented // unimplemented