From a34a97d88d9aac5f0ca8422243ea15c89fa8d880 Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Tue, 9 Aug 2022 00:25:32 +0700 Subject: [PATCH] cmd/compile: disable append of make test on noopt builder Updates #53888 Change-Id: I34ef2c5bd23816e1991cfec2bef4cae72676b523 Reviewed-on: https://go-review.googlesource.com/c/go/+/422037 Reviewed-by: Than McIntosh Reviewed-by: Keith Randall TryBot-Result: Gopher Robot Reviewed-by: Keith Randall Run-TryBot: Cuong Manh Le Auto-Submit: Cuong Manh Le --- src/cmd/compile/internal/test/issue53888_test.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/cmd/compile/internal/test/issue53888_test.go b/src/cmd/compile/internal/test/issue53888_test.go index 9f50a82a3c6..032412afcfb 100644 --- a/src/cmd/compile/internal/test/issue53888_test.go +++ b/src/cmd/compile/internal/test/issue53888_test.go @@ -2,15 +2,21 @@ // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. -//go:build !race +//go:build !race && !goexperiment.unified package test import ( + "internal/testenv" + "strings" "testing" ) +// TODO(cuonglm,mdempsky): figure out why Unifed IR failed? func TestAppendOfMake(t *testing.T) { + if strings.HasSuffix(testenv.Builder(), "-noopt") { + t.Skip("append of make optimization is disabled on noopt builder") + } for n := 32; n < 33; n++ { // avoid stack allocation of make() b := make([]byte, n) f := func() {