From a295b3cec80b048048bf51a0462764dc337ca6ef Mon Sep 17 00:00:00 2001 From: Matthew Dempsky Date: Wed, 8 Sep 2021 14:03:53 -0700 Subject: [PATCH] test: re-enable AsmCheck tests for types2-based frontends run.go has logic for being able to run tests with various -G flags, but not all test types (in particular, "asmcheck" tests) support configuring non-default -G levels. The intention was that these tests would continue running in the default mode (at the time -G=0), but at some point it seems like we accidentally disabled them all together (if it ever worked correctly in the first place). Fixes #48247. Change-Id: I13917cb0012cbe522d29b23b888de6136872ead4 Reviewed-on: https://go-review.googlesource.com/c/go/+/348671 Trust: Matthew Dempsky Run-TryBot: Matthew Dempsky TryBot-Result: Go Bot Reviewed-by: Michael Munday --- test/run.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/test/run.go b/test/run.go index 76621d92428..790b54bfd2c 100644 --- a/test/run.go +++ b/test/run.go @@ -780,11 +780,13 @@ func (t *test) run() { } default: - // we don't know how to add -G for this test yet - if *verbose { - fmt.Printf("excl\t%s\n", t.goFileName()) + if t.glevel != CompilerDefaultGLevel { + // we don't know how to add -G for this test yet + if *verbose { + fmt.Printf("excl\t%s\n", t.goFileName()) + } + return false } - return false } return true