qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 18:16:48 -07:00
Code Releases Activity

cmd/compile/internal/gc: correctly use internal call to error reporting

Browse Source 
Fixes #13266.

Change-Id: I31da922e0599989e52acf346374c2077b157ebb7
Reviewed-on: https://go-review.googlesource.com/16971
Reviewed-by: Chris Manghane <cmang@golang.org>
This commit is contained in:
Robert Griesemer 2015-11-16 11:24:43 -08:00
parent f9357cdec1
commit a20556bf56
2 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cmd/compile/internal/gc/parser.go
View File

@ -116,7 +116,7 @@ func (p *parser) syntax_error(msg string) {
msg = ", " + msg msg = ", " + msg
default: default:
// plain error - we don't care about current token // plain error - we don't care about current token
Yyerror("syntax error: " + msg) Yyerror("syntax error: %s", msg)
return return
} }
@ -138,7 +138,7 @@ func (p *parser) syntax_error(msg string) {
tok = tokstring(p.tok) tok = tokstring(p.tok)
} }
Yyerror("syntax error: unexpected " + tok + msg) Yyerror("syntax error: unexpected %s", tok + msg)
} }
// Advance consumes tokens until it finds a token of the stoplist. // Advance consumes tokens until it finds a token of the stoplist.
@ -1669,7 +1669,7 @@ func (p *parser) sym() *Sym {
return nil return nil
default: default:
p.syntax_error("") p.syntax_error("expecting name")
p.advance() p.advance()
return new(Sym) return new(Sym)
} }

10
test/fixedbugs/issue13266.go Normal file
View File

@ -0,0 +1,10 @@
// errorcheck
// Copyright 2015 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Offending character % must not be interpreted as
// start of format verb when emitting error message.
package% // ERROR "unexpected %"