qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-29 12:04:28 -06:00
Code Releases Activity

cmd/go/internal/clean: make 'go clean -testcache' a no-op if the cache directory is gone

Browse Source 
Fixes #29100

Change-Id: I195191aad825266ab55d38addef9d662cfc72dff
Reviewed-on: https://go-review.googlesource.com/c/go/+/212099
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
This commit is contained in:
Bryan C. Mills 2019-12-19 09:33:16 -05:00
parent 5481a97ab0
commit a197c7bbf2
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/go/internal/clean/clean.go
View File

@ -178,10 +178,12 @@ func runClean(cmd *base.Command, args []string) {
} }
} }
if err != nil { if err != nil {
if _, statErr := os.Stat(dir); !os.IsNotExist(statErr) {
base.Errorf("go clean -testcache: %v", err) base.Errorf("go clean -testcache: %v", err)
} }
} }
} }
}
if cleanModcache { if cleanModcache {
if modfetch.PkgMod == "" { if modfetch.PkgMod == "" {

7
src/cmd/go/testdata/script/clean_testcache.txt vendored
View File

@ -9,6 +9,13 @@ go clean -testcache
go test x_test.go go test x_test.go
! stdout 'cached' ! stdout 'cached'
# golang.org/issue/29100: 'go clean -testcache' should succeed
# if the cache directory doesn't exist at all.
# It should not write a testexpire.txt file, since there are no
# test results that need to be invalidated in the first place.
env GOCACHE=$WORK/nonexistent
go clean -testcache
! exists $WORK/nonexistent
-- x/x_test.go -- -- x/x_test.go --
package x_test package x_test