1
0
mirror of https://github.com/golang/go synced 2024-11-19 16:34:49 -07:00

cmd/vendor/.../pprof: do not run test that opens web browser

Obviously not OK.

For #22651.

Change-Id: I4238045bec6e50788daaa27a7fbc1d547e72cde9
Reviewed-on: https://go-review.googlesource.com/76870
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
This commit is contained in:
Russ Cox 2017-11-09 20:38:11 -05:00
parent 821e3f7d85
commit a10884838a

View File

@ -25,13 +25,22 @@ import (
"regexp"
"sync"
"testing"
"time"
"runtime"
"github.com/google/pprof/internal/plugin"
"github.com/google/pprof/profile"
"runtime"
)
func TestWebInterface(t *testing.T) {
// This test starts a web browser in a background goroutine
// after a 500ms delay. Sometimes the test exits before it
// can run the browser, but sometimes the browser does open.
// That's obviously unacceptable.
defer time.Sleep(2 * time.Second) // to see the browser open
t.Skip("golang.org/issue/22651")
if runtime.GOOS == "nacl" {
t.Skip("test assumes tcp available")
}
@ -124,6 +133,8 @@ func TestWebInterface(t *testing.T) {
}
}
wg.Wait()
time.Sleep(5 * time.Second)
}
// Implement fake object file support.