qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 16:54:43 -07:00
Code Releases Activity

internal/lsp: fix race in checkPackageHandles

Browse Source 
We were caching the package before setting the handle, so a
checkPackageHandle might be in use before it was fully created.

Change-Id: Ic98e7c351cbed5e4caa87098e95ad04d4f54f8df
Reviewed-on: https://go-review.googlesource.com/c/tools/+/202040
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Rebecca Stambler 2019-10-18 15:14:59 -04:00
parent 0bbdbb2ef6
commit a1005cf9b2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/lsp/cache/check.go vendored
View File

@ -99,6 +99,9 @@ func (imp *importer) checkPackageHandle(ctx context.Context, id packageID) (*che
})
cph.handle = h
// Cache the CheckPackageHandle in the snapshot.
imp.snapshot.addPackage(cph)
return cph, nil
}
@ -147,9 +150,6 @@ func (imp *importer) buildKey(ctx context.Context, id packageID, mode source.Par
}
cph.key = checkPackageKey(cph.m.id, cph.files, m.config, depKeys)
// Cache the CheckPackageHandle in the snapshot.
imp.snapshot.addPackage(cph)
return cph, nil
}