qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 20:04:52 -07:00
Code Releases Activity

fmt: fix internal unknownType function

Browse Source 
This thing should never be called, but before
151960044 it was being called, incorrectly.
This is now just a precaution but let's pretend it
Fixes #8843
even though that was fixed by 151960044.
The test case was already there and ran, another mystery.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/151970043
This commit is contained in:
Rob Pike 2014-10-01 21:35:12 +00:00
parent 62d3202aaa
commit 9f4084278f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/fmt/print.go
View File

@ -297,13 +297,13 @@ func parsenum(s string, start, end int) (num int, isnum bool, newi int) {
return
}
func (p *pp) unknownType(v interface{}) {
if v == nil {
func (p *pp) unknownType(v reflect.Value) {
if !v.IsValid() {
p.buf.Write(nilAngleBytes)
return
}
p.buf.WriteByte('?')
p.buf.WriteString(reflect.TypeOf(v).String())
p.buf.WriteString(v.Type().String())
p.buf.WriteByte('?')
}