qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-11 18:21:40 -07:00
Code Releases Activity

cmd/compile: do not report error for invalid constant

Browse Source 
Invalid constant was already reported by noder, so don't re-check in
typecheck, which lead to compiler crashing.

Updates #43311

Change-Id: I48e2f540601cef725c1ff628c066ed15d848e771
Reviewed-on: https://go-review.googlesource.com/c/go/+/298713
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
This commit is contained in:
Cuong Manh Le 2021-03-04 22:24:58 +07:00
parent 51d8d351c1
commit 9e6b1fcd0a
4 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/compile/internal/noder/noder.go
View File

@ -689,7 +689,7 @@ func (p *noder) expr(expr syntax.Expr) ir.Node {
if expr.Kind == syntax.RuneLit { if expr.Kind == syntax.RuneLit {
n.SetType(types.UntypedRune) n.SetType(types.UntypedRune)
} }
n.SetDiag(expr.Bad) // avoid follow-on errors if there was a syntax error n.SetDiag(expr.Bad || n.Val().Kind() == constant.Unknown) // avoid follow-on errors if there was a syntax error
return n return n
case *syntax.CompositeLit: case *syntax.CompositeLit:
n := ir.NewCompLitExpr(p.pos(expr), ir.OCOMPLIT, p.typeExpr(expr.Type), nil) n := ir.NewCompLitExpr(p.pos(expr), ir.OCOMPLIT, p.typeExpr(expr.Type), nil)

4
src/cmd/compile/internal/typecheck/typecheck.go
View File

@ -482,7 +482,9 @@ func typecheck1(n ir.Node, top int) ir.Node {
case ir.OLITERAL: case ir.OLITERAL:
if n.Sym() == nil && n.Type() == nil { if n.Sym() == nil && n.Type() == nil {
base.Fatalf("literal missing type: %v", n) if !n.Diag() {
base.Fatalf("literal missing type: %v", n)
}
} }
return n return n

2
test/char_lit1.go
View File

@ -1,4 +1,4 @@
// errorcheck // errorcheck -d=panic
// Copyright 2009 The Go Authors. All rights reserved. // Copyright 2009 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style // Use of this source code is governed by a BSD-style

2
test/fixedbugs/issue20232.go
View File

@ -1,4 +1,4 @@
// errorcheck // errorcheck -d=panic
// Copyright 2017 The Go Authors. All rights reserved. // Copyright 2017 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style // Use of this source code is governed by a BSD-style