mirror of
https://github.com/golang/go
synced 2024-11-23 20:00:04 -07:00
all: update stale test skips
Issues #10043, #15405, and #22660 appear to have been fixed, and whatever tests I could run locally do succeed, so remove the skips. Issue #7237 was closed in favor of #17906, so update its skip line. Issue #7634 was closed as it had not appeared for over three years. Re-enable it for now. An issue should be open if the test starts being skipped again. Change-Id: I67daade906744ed49223291035baddaad9f56dca Reviewed-on: https://go-review.googlesource.com/121735 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
parent
0566ab3383
commit
9e4d87d115
@ -4008,8 +4008,6 @@ func TestCgoConsistentResults(t *testing.T) {
|
||||
t.Skip("skipping because cgo not enabled")
|
||||
}
|
||||
switch runtime.GOOS {
|
||||
case "freebsd":
|
||||
testenv.SkipFlaky(t, 15405)
|
||||
case "solaris":
|
||||
testenv.SkipFlaky(t, 13247)
|
||||
}
|
||||
|
@ -2988,7 +2988,7 @@ func testRequestBodyLimit(t *testing.T, h2 bool) {
|
||||
// side of their TCP connection, the server doesn't send a 400 Bad Request.
|
||||
func TestClientWriteShutdown(t *testing.T) {
|
||||
if runtime.GOOS == "plan9" {
|
||||
t.Skip("skipping test; see https://golang.org/issue/7237")
|
||||
t.Skip("skipping test; see https://golang.org/issue/17906")
|
||||
}
|
||||
defer afterTest(t)
|
||||
ts := httptest.NewServer(HandlerFunc(func(w ResponseWriter, r *Request) {}))
|
||||
|
@ -21,7 +21,6 @@ import (
|
||||
"errors"
|
||||
"fmt"
|
||||
"internal/nettrace"
|
||||
"internal/testenv"
|
||||
"io"
|
||||
"io/ioutil"
|
||||
"log"
|
||||
@ -2726,7 +2725,6 @@ func TestTransportTLSHandshakeTimeout(t *testing.T) {
|
||||
// Trying to repro golang.org/issue/3514
|
||||
func TestTLSServerClosesConnection(t *testing.T) {
|
||||
defer afterTest(t)
|
||||
testenv.SkipFlaky(t, 7634)
|
||||
|
||||
closedc := make(chan bool, 1)
|
||||
ts := httptest.NewTLSServer(HandlerFunc(func(w ResponseWriter, r *Request) {
|
||||
|
@ -425,10 +425,6 @@ func TestOverflowSleep(t *testing.T) {
|
||||
// Test that a panic while deleting a timer does not leave
|
||||
// the timers mutex held, deadlocking a ticker.Stop in a defer.
|
||||
func TestIssue5745(t *testing.T) {
|
||||
if runtime.GOOS == "darwin" && runtime.GOARCH == "arm" {
|
||||
t.Skipf("skipping on %s/%s, see issue 10043", runtime.GOOS, runtime.GOARCH)
|
||||
}
|
||||
|
||||
ticker := NewTicker(Hour)
|
||||
defer func() {
|
||||
// would deadlock here before the fix due to
|
||||
|
Loading…
Reference in New Issue
Block a user