From 9c3869d25933f4e885e0174fde666dba3faca764 Mon Sep 17 00:00:00 2001
From: Michael Matloob <matloob@golang.org>
Date: Mon, 30 Dec 2019 19:45:29 -0500
Subject: [PATCH] cmd/go: convert TestGoTestImportErrorStack to the script
 framework

The literal string match had to be turned into a regexp, otherwise
pretty straightforward.

Part of converting all tests to script framework to improve
test parallelism.

Updates #36320
Updates #17751

Change-Id: I46f62312f02dc9adf83ed91c6f807420d29fbb12
Reviewed-on: https://go-review.googlesource.com/c/go/+/212939
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
---
 src/cmd/go/go_test.go                           | 14 --------------
 .../testdata/script/test_import_error_stack.txt | 17 +++++++++++++++++
 src/cmd/go/testdata/src/testdep/p1/p1.go        |  1 -
 src/cmd/go/testdata/src/testdep/p1/p1_test.go   |  3 ---
 src/cmd/go/testdata/src/testdep/p2/p2.go        |  3 ---
 src/cmd/go/testdata/src/testdep/p3/p3.go        |  3 ---
 6 files changed, 17 insertions(+), 24 deletions(-)
 create mode 100644 src/cmd/go/testdata/script/test_import_error_stack.txt
 delete mode 100644 src/cmd/go/testdata/src/testdep/p1/p1.go
 delete mode 100644 src/cmd/go/testdata/src/testdep/p1/p1_test.go
 delete mode 100644 src/cmd/go/testdata/src/testdep/p2/p2.go
 delete mode 100644 src/cmd/go/testdata/src/testdep/p3/p3.go

diff --git a/src/cmd/go/go_test.go b/src/cmd/go/go_test.go
index c842559b6e5..45d9ab6a893 100644
--- a/src/cmd/go/go_test.go
+++ b/src/cmd/go/go_test.go
@@ -3220,20 +3220,6 @@ func TestGoTestRaceFailures(t *testing.T) {
 	tg.grepBothNot("PASS", "something passed")
 }
 
-func TestGoTestImportErrorStack(t *testing.T) {
-	const out = `package testdep/p1 (test)
-	imports testdep/p2
-	imports testdep/p3: build constraints exclude all Go files `
-
-	tg := testgo(t)
-	defer tg.cleanup()
-	tg.setenv("GOPATH", filepath.Join(tg.pwd(), "testdata"))
-	tg.runFail("test", "testdep/p1")
-	if !strings.Contains(tg.stderr.String(), out) {
-		t.Fatalf("did not give full import stack:\n\n%s", tg.stderr.String())
-	}
-}
-
 func TestGoGetUpdate(t *testing.T) {
 	// golang.org/issue/9224.
 	// The recursive updating was trying to walk to
diff --git a/src/cmd/go/testdata/script/test_import_error_stack.txt b/src/cmd/go/testdata/script/test_import_error_stack.txt
new file mode 100644
index 00000000000..3b796053f7c
--- /dev/null
+++ b/src/cmd/go/testdata/script/test_import_error_stack.txt
@@ -0,0 +1,17 @@
+! go test testdep/p1
+stderr 'package testdep/p1 \(test\)\n\timports testdep/p2\n\timports testdep/p3: build constraints exclude all Go files ' # check for full import stack
+
+-- testdep/p1/p1.go --
+package p1
+-- testdep/p1/p1_test.go --
+package p1
+
+import _ "testdep/p2"
+-- testdep/p2/p2.go --
+package p2
+
+import _ "testdep/p3"
+-- testdep/p3/p3.go --
+// +build ignore
+
+package ignored
diff --git a/src/cmd/go/testdata/src/testdep/p1/p1.go b/src/cmd/go/testdata/src/testdep/p1/p1.go
deleted file mode 100644
index a457035a430..00000000000
--- a/src/cmd/go/testdata/src/testdep/p1/p1.go
+++ /dev/null
@@ -1 +0,0 @@
-package p1
diff --git a/src/cmd/go/testdata/src/testdep/p1/p1_test.go b/src/cmd/go/testdata/src/testdep/p1/p1_test.go
deleted file mode 100644
index 8be75334425..00000000000
--- a/src/cmd/go/testdata/src/testdep/p1/p1_test.go
+++ /dev/null
@@ -1,3 +0,0 @@
-package p1
-
-import _ "testdep/p2"
diff --git a/src/cmd/go/testdata/src/testdep/p2/p2.go b/src/cmd/go/testdata/src/testdep/p2/p2.go
deleted file mode 100644
index 15ba2eacea5..00000000000
--- a/src/cmd/go/testdata/src/testdep/p2/p2.go
+++ /dev/null
@@ -1,3 +0,0 @@
-package p2
-
-import _ "testdep/p3"
diff --git a/src/cmd/go/testdata/src/testdep/p3/p3.go b/src/cmd/go/testdata/src/testdep/p3/p3.go
deleted file mode 100644
index 0219e7fae50..00000000000
--- a/src/cmd/go/testdata/src/testdep/p3/p3.go
+++ /dev/null
@@ -1,3 +0,0 @@
-// +build ignore
-
-package ignored