qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 13:04:45 -07:00
Code Releases Activity

runtime: reset mark state before stopping the world

Browse Source 
Currently we reset the mark state during STW sweep termination. This
involves looping over all of the goroutines. Each iteration of this
loop takes ~25ns, so at around 400k goroutines, we'll exceed our 10ms
pause goal.

However, it's safe to do this before we stop the world for sweep
termination because nothing is consuming this state yet. Hence, move
the reset to just before STW.

This isn't perfect: a long reset can still delay allocating goroutines
that block on GC starting. But it's certainly better to block some
things eventually than to block everything immediately.

For 1.6.x.

Fixes #14420.

name \ 95%ile-time/sweepTerm           old          new  delta
500kIdleGs-12                 11312µs ± 6%  18.9µs ± 6%  -99.83%  (p=0.000 n=16+20)

Change-Id: I9815c4d8d9b0d3c3e94dfdab78049cefe0dcc93c
Reviewed-on: https://go-review.googlesource.com/20147
Reviewed-by: Rick Hudson <rlh@golang.org>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Austin Clements 2016-03-01 15:09:24 -05:00
parent 1716162a9a
commit 9ab9053344
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/runtime/mgc.go
View File

@ -933,6 +933,9 @@ func gcStart(mode gcMode, forceTrigger bool) {
if mode == gcBackgroundMode { if mode == gcBackgroundMode {
gcBgMarkStartWorkers() gcBgMarkStartWorkers()
} }
gcResetMarkState()
now := nanotime() now := nanotime()
work.stwprocs, work.maxprocs = gcprocs(), gomaxprocs work.stwprocs, work.maxprocs = gcprocs(), gomaxprocs
work.tSweepTerm = now work.tSweepTerm = now
@ -950,8 +953,6 @@ func gcStart(mode gcMode, forceTrigger bool) {
// reclaimed until the next GC cycle. // reclaimed until the next GC cycle.
clearpools() clearpools()
gcResetMarkState()
work.finalizersDone = false work.finalizersDone = false
if mode == gcBackgroundMode { // Do as much work concurrently as possible if mode == gcBackgroundMode { // Do as much work concurrently as possible
@ -1724,8 +1725,10 @@ func gcCopySpans() {
} }
// gcResetMarkState resets global state prior to marking (concurrent // gcResetMarkState resets global state prior to marking (concurrent
// or STW) and resets the stack scan state of all Gs. Any Gs created // or STW) and resets the stack scan state of all Gs.
// after this will also be in the reset state. //
// This is safe to do without the world stopped because any Gs created
// during or after this will start out in the reset state.
func gcResetMarkState() { func gcResetMarkState() {
// This may be called during a concurrent phase, so make sure // This may be called during a concurrent phase, so make sure
// allgs doesn't change. // allgs doesn't change.