qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 09:54:46 -07:00
Code Releases Activity

[dev.typeparams] cmd/compile: refactor escape analysis of calls

Browse Source 
This CL is a prep refactoring for an upcoming CL to move go/defer
wrapping into escape analysis. That CL is unfortunately unavoidably
complex and subtle, so this CL takes care of some more mundane
refactoring details.

Change-Id: Ifbefe1d522a8d57066646be09536437f42e7082c
Reviewed-on: https://go-review.googlesource.com/c/go/+/330251
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
This commit is contained in:
Matthew Dempsky 2021-06-22 20:53:14 -07:00
parent 1a445dab66
commit 99732b9070
3 changed files with 48 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

78
src/cmd/compile/internal/escape/call.go
View File

@ -13,26 +13,24 @@ import (
// call evaluates a call expressions, including builtin calls. ks // call evaluates a call expressions, including builtin calls. ks
// should contain the holes representing where the function callee's // should contain the holes representing where the function callee's
// results flows; where is the OGO/ODEFER context of the call, if any. // results flows.
func (e *escape) call(ks []hole, call, where ir.Node) { func (e *escape) call(ks []hole, call ir.Node) {
topLevelDefer := where != nil && where.Op() == ir.ODEFER && e.loopDepth == 1 e.callCommon(ks, call, nil)
if topLevelDefer { }
// force stack allocation of defer record, unless
// open-coded defers are used (see ssa.go)
where.SetEsc(ir.EscNever)
}
argument := func(k hole, arg ir.Node) { func (e *escape) callCommon(ks []hole, call ir.Node, where *ir.GoDeferStmt) {
if topLevelDefer { argument := func(k hole, argp *ir.Node) {
// Top level defers arguments don't escape to if where != nil {
// heap, but they do need to last until end of if where.Esc() == ir.EscNever {
// function. // Top-level defers arguments don't escape to heap,
k = e.later(k) // but they do need to last until end of function.
} else if where != nil { k = e.later(k)
k = e.heapHole() } else {
k = e.heapHole()
}
} }
e.expr(k.note(call, "call parameter"), arg) e.expr(k.note(call, "call parameter"), *argp)
} }
switch call.Op() { switch call.Op() {
@ -70,15 +68,15 @@ func (e *escape) call(ks []hole, call, where ir.Node) {
} }
if r := fntype.Recv(); r != nil { if r := fntype.Recv(); r != nil {
argument(e.tagHole(ks, fn, r), call.X.(*ir.SelectorExpr).X) argument(e.tagHole(ks, fn, r), &call.X.(*ir.SelectorExpr).X)
} else { } else {
// Evaluate callee function expression. // Evaluate callee function expression.
argument(e.discardHole(), call.X) argument(e.discardHole(), &call.X)
} }
args := call.Args args := call.Args
for i, param := range fntype.Params().FieldSlice() { for i, param := range fntype.Params().FieldSlice() {
argument(e.tagHole(ks, fn, param), args[i]) argument(e.tagHole(ks, fn, param), &args[i])
} }
case ir.OAPPEND: case ir.OAPPEND:
@ -93,54 +91,66 @@ func (e *escape) call(ks []hole, call, where ir.Node) {
if args[0].Type().Elem().HasPointers() { if args[0].Type().Elem().HasPointers() {
appendeeK = e.teeHole(appendeeK, e.heapHole().deref(call, "appendee slice")) appendeeK = e.teeHole(appendeeK, e.heapHole().deref(call, "appendee slice"))
} }
argument(appendeeK, args[0]) argument(appendeeK, &args[0])
if call.IsDDD { if call.IsDDD {
appendedK := e.discardHole() appendedK := e.discardHole()
if args[1].Type().IsSlice() && args[1].Type().Elem().HasPointers() { if args[1].Type().IsSlice() && args[1].Type().Elem().HasPointers() {
appendedK = e.heapHole().deref(call, "appended slice...") appendedK = e.heapHole().deref(call, "appended slice...")
} }
argument(appendedK, args[1]) argument(appendedK, &args[1])
} else { } else {
for _, arg := range args[1:] { for i := 1; i < len(args); i++ {
argument(e.heapHole(), arg) argument(e.heapHole(), &args[i])
} }
} }
case ir.OCOPY: case ir.OCOPY:
call := call.(*ir.BinaryExpr) call := call.(*ir.BinaryExpr)
argument(e.discardHole(), call.X) argument(e.discardHole(), &call.X)
copiedK := e.discardHole() copiedK := e.discardHole()
if call.Y.Type().IsSlice() && call.Y.Type().Elem().HasPointers() { if call.Y.Type().IsSlice() && call.Y.Type().Elem().HasPointers() {
copiedK = e.heapHole().deref(call, "copied slice") copiedK = e.heapHole().deref(call, "copied slice")
} }
argument(copiedK, call.Y) argument(copiedK, &call.Y)
case ir.OPANIC: case ir.OPANIC:
call := call.(*ir.UnaryExpr) call := call.(*ir.UnaryExpr)
argument(e.heapHole(), call.X) argument(e.heapHole(), &call.X)
case ir.OCOMPLEX: case ir.OCOMPLEX:
call := call.(*ir.BinaryExpr) call := call.(*ir.BinaryExpr)
argument(e.discardHole(), call.X) argument(e.discardHole(), &call.X)
argument(e.discardHole(), call.Y) argument(e.discardHole(), &call.Y)
case ir.ODELETE, ir.OPRINT, ir.OPRINTN, ir.ORECOVER: case ir.ODELETE, ir.OPRINT, ir.OPRINTN, ir.ORECOVER:
call := call.(*ir.CallExpr) call := call.(*ir.CallExpr)
for _, arg := range call.Args { for i := range call.Args {
argument(e.discardHole(), arg) argument(e.discardHole(), &call.Args[i])
} }
case ir.OLEN, ir.OCAP, ir.OREAL, ir.OIMAG, ir.OCLOSE: case ir.OLEN, ir.OCAP, ir.OREAL, ir.OIMAG, ir.OCLOSE:
call := call.(*ir.UnaryExpr) call := call.(*ir.UnaryExpr)
argument(e.discardHole(), call.X) argument(e.discardHole(), &call.X)
case ir.OUNSAFEADD, ir.OUNSAFESLICE: case ir.OUNSAFEADD, ir.OUNSAFESLICE:
call := call.(*ir.BinaryExpr) call := call.(*ir.BinaryExpr)
argument(ks[0], call.X) argument(ks[0], &call.X)
argument(e.discardHole(), call.Y) argument(e.discardHole(), &call.Y)
} }
} }
func (e *escape) goDeferStmt(n *ir.GoDeferStmt) {
topLevelDefer := n.Op() == ir.ODEFER && e.loopDepth == 1
if topLevelDefer {
// force stack allocation of defer record, unless
// open-coded defers are used (see ssa.go)
n.SetEsc(ir.EscNever)
}
e.stmts(n.Call.Init())
e.callCommon(nil, n.Call, n)
}
// tagHole returns a hole for evaluating an argument passed to param. // tagHole returns a hole for evaluating an argument passed to param.
// ks should contain the holes representing where the function // ks should contain the holes representing where the function
// callee's results flows. fn is the statically-known callee function, // callee's results flows. fn is the statically-known callee function,

2
src/cmd/compile/internal/escape/expr.go
View File

@ -139,7 +139,7 @@ func (e *escape) exprSkipInit(k hole, n ir.Node) {
e.discard(n.X) e.discard(n.X)
case ir.OCALLMETH, ir.OCALLFUNC, ir.OCALLINTER, ir.OLEN, ir.OCAP, ir.OCOMPLEX, ir.OREAL, ir.OIMAG, ir.OAPPEND, ir.OCOPY, ir.OUNSAFEADD, ir.OUNSAFESLICE: case ir.OCALLMETH, ir.OCALLFUNC, ir.OCALLINTER, ir.OLEN, ir.OCAP, ir.OCOMPLEX, ir.OREAL, ir.OIMAG, ir.OAPPEND, ir.OCOPY, ir.OUNSAFEADD, ir.OUNSAFESLICE:
e.call([]hole{k}, n, nil) e.call([]hole{k}, n)
case ir.ONEW: case ir.ONEW:
n := n.(*ir.UnaryExpr) n := n.(*ir.UnaryExpr)

7
src/cmd/compile/internal/escape/stmt.go
View File

@ -163,7 +163,7 @@ func (e *escape) stmt(n ir.Node) {
n := n.(*ir.AssignListStmt) n := n.(*ir.AssignListStmt)
e.stmts(n.Rhs[0].Init()) e.stmts(n.Rhs[0].Init())
ks := e.addrs(n.Lhs) ks := e.addrs(n.Lhs)
e.call(ks, n.Rhs[0], nil) e.call(ks, n.Rhs[0])
e.reassigned(ks, n) e.reassigned(ks, n)
case ir.ORETURN: case ir.ORETURN:
n := n.(*ir.ReturnStmt) n := n.(*ir.ReturnStmt)
@ -174,11 +174,10 @@ func (e *escape) stmt(n ir.Node) {
} }
e.assignList(dsts, n.Results, "return", n) e.assignList(dsts, n.Results, "return", n)
case ir.OCALLFUNC, ir.OCALLMETH, ir.OCALLINTER, ir.OCLOSE, ir.OCOPY, ir.ODELETE, ir.OPANIC, ir.OPRINT, ir.OPRINTN, ir.ORECOVER: case ir.OCALLFUNC, ir.OCALLMETH, ir.OCALLINTER, ir.OCLOSE, ir.OCOPY, ir.ODELETE, ir.OPANIC, ir.OPRINT, ir.OPRINTN, ir.ORECOVER:
e.call(nil, n, nil) e.call(nil, n)
case ir.OGO, ir.ODEFER: case ir.OGO, ir.ODEFER:
n := n.(*ir.GoDeferStmt) n := n.(*ir.GoDeferStmt)
e.stmts(n.Call.Init()) e.goDeferStmt(n)
e.call(nil, n.Call, n)
case ir.OTAILCALL: case ir.OTAILCALL:
// TODO(mdempsky): Treat like a normal call? esc.go used to just ignore it. // TODO(mdempsky): Treat like a normal call? esc.go used to just ignore it.