From 99159cda330e8f71b9e7e5a5287d0f8395836d4c Mon Sep 17 00:00:00 2001 From: qmuntal Date: Thu, 30 Mar 2023 11:04:48 +0200 Subject: [PATCH] net: unskip TestConcurrentPreferGoResolversDial on Windows Windows resolver uses the Dial function since CL 409234. Change-Id: Id631a84d2b85fc4f8897e413a0a454cf54c00de4 Reviewed-on: https://go-review.googlesource.com/c/go/+/480418 TryBot-Result: Gopher Robot Reviewed-by: Bryan Mills Reviewed-by: Matthew Dempsky Run-TryBot: Quim Muntal --- src/net/lookup_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/net/lookup_test.go b/src/net/lookup_test.go index 0868b1f083a..dfcf62b1c49 100644 --- a/src/net/lookup_test.go +++ b/src/net/lookup_test.go @@ -1028,10 +1028,10 @@ func (lcr *lookupCustomResolver) dial() func(ctx context.Context, network, addre // TestConcurrentPreferGoResolversDial tests that multiple resolvers with the // PreferGo option used concurrently are all dialed properly. func TestConcurrentPreferGoResolversDial(t *testing.T) { - // The windows and plan9 implementation of the resolver does not use - // the Dial function. switch runtime.GOOS { - case "windows", "plan9": + case "plan9": + // TODO: plan9 implementation of the resolver uses the Dial function since + // https://go.dev/cl/409234, this test could probably be reenabled. t.Skipf("skip on %v", runtime.GOOS) }