1
0
mirror of https://github.com/golang/go synced 2024-11-15 00:20:30 -07:00

cmd/preprofile: drop output directory check

This check serves only to provide a more descriptive error if the output
directory doesn't exist. That isn't useless, but I don't see why this tool
specifically should do this when no other part of the toolchain does.

For #58102.

Change-Id: I01cf9db2cc1dad85c3afd8a6b008c53f26cb877a
Reviewed-on: https://go-review.googlesource.com/c/go/+/569336
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Michael Pratt 2024-03-04 13:20:43 -05:00
parent a16b4bf30c
commit 979b34b37c

View File

@ -19,7 +19,6 @@ import (
"internal/profile" "internal/profile"
"log" "log"
"os" "os"
"path/filepath"
"strconv" "strconv"
) )
@ -132,21 +131,11 @@ func preprocess(profileFile string, outputFile string, verbose bool) error {
if outputFile == "" { if outputFile == "" {
fNodeMap = os.Stdout fNodeMap = os.Stdout
} else { } else {
dirPath := filepath.Dir(outputFile)
_, err := os.Stat(dirPath)
if err != nil {
return fmt.Errorf("directory does not exist: %s", dirPath)
}
base := filepath.Base(outputFile)
outputFile = filepath.Join(dirPath, base)
// write out NodeMap to a file
fNodeMap, err = os.Create(outputFile) fNodeMap, err = os.Create(outputFile)
if err != nil { if err != nil {
return fmt.Errorf("Error creating output file: %w", err) return fmt.Errorf("Error creating output file: %w", err)
} }
defer fNodeMap.Close()
defer fNodeMap.Close() // Close the file when done writing
} }
w := bufio.NewWriter(fNodeMap) w := bufio.NewWriter(fNodeMap)