qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 14:24:47 -07:00
Code Releases Activity

all: remove unnecessary return after skipping test

Browse Source 
testing.Skip{,f} will exit the test via runtime.Goexit. Thus, the
successive return is never reached and can be removed.

Change-Id: I1e399f3d5db753ece1ffba648850427e1b4be300
Reviewed-on: https://go-review.googlesource.com/74990
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
This commit is contained in:
Tobias Klauser 2017-11-01 11:03:41 +01:00 committed by Daniel Martí
parent 2c783dc038
commit 96c62b3b31
3 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/go/internal/gccgoimporter/gccgoinstallation_test.go
View File

@ -152,7 +152,6 @@ func TestInstallationImporter(t *testing.T) {
// were compiled with gccgo. // were compiled with gccgo.
if runtime.Compiler != "gccgo" { if runtime.Compiler != "gccgo" {
t.Skip("This test needs gccgo") t.Skip("This test needs gccgo")
return
} }
var inst GccgoInstallation var inst GccgoInstallation

1
src/go/internal/gccgoimporter/importer_test.go
View File

@ -122,7 +122,6 @@ func TestObjImporter(t *testing.T) {
// were compiled with gccgo. // were compiled with gccgo.
if runtime.Compiler != "gccgo" { if runtime.Compiler != "gccgo" {
t.Skip("This test needs gccgo") t.Skip("This test needs gccgo")
return
} }
tmpdir, err := ioutil.TempDir("", "") tmpdir, err := ioutil.TempDir("", "")

2
src/runtime/pprof/pprof_test.go
View File

@ -179,7 +179,6 @@ func testCPUProfile(t *testing.T, need []string, f func(dur time.Duration)) {
if badOS[runtime.GOOS] { if badOS[runtime.GOOS] {
t.Skipf("ignoring failure on %s; see golang.org/issue/13841", runtime.GOOS) t.Skipf("ignoring failure on %s; see golang.org/issue/13841", runtime.GOOS)
return
} }
// Ignore the failure if the tests are running in a QEMU-based emulator, // Ignore the failure if the tests are running in a QEMU-based emulator,
// QEMU is not perfect at emulating everything. // QEMU is not perfect at emulating everything.
@ -187,7 +186,6 @@ func testCPUProfile(t *testing.T, need []string, f func(dur time.Duration)) {
// IN_QEMU=1 indicates that the tests are running in QEMU. See issue 9605. // IN_QEMU=1 indicates that the tests are running in QEMU. See issue 9605.
if os.Getenv("IN_QEMU") == "1" { if os.Getenv("IN_QEMU") == "1" {
t.Skip("ignore the failure in QEMU; see golang.org/issue/9605") t.Skip("ignore the failure in QEMU; see golang.org/issue/9605")
return
} }
t.FailNow() t.FailNow()
} }